Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/cmd/golangorg: TestWeb fails when 'go' command is not available #33946

Closed
bcmills opened this issue Aug 29, 2019 · 1 comment
Closed

x/website/cmd/golangorg: TestWeb fails when 'go' command is not available #33946

bcmills opened this issue Aug 29, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2019

On the illumos-amd64-joyent builder (https://build.golang.org/log/2e000534befacffec5824cc7505e627b1c006926):

--- FAIL: TestWeb (0.00s)
    godoc_test.go:48: Building godoc: exec: "go": executable file not found in $PATH
FAIL
FAIL	golang.org/x/website/cmd/golangorg	0.032s
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Aug 29, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2019
@gopherbot
Copy link

Change https://golang.org/cl/192329 mentions this issue: cmd/golangorg: skip tests that require godoc when the 'go' binary is not available to build it

@bcmills bcmills mentioned this issue Aug 29, 2019
Open
@golang golang locked and limited conversation to collaborators Aug 28, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
cmd/golangorg: skip tests that require godoc when the 'go' binary is …
3a4459a 
…not available to build it

Fixes golang/go#33946

Change-Id: Ib4d14a3acad1c610e4c07dcff1a56757cd9492c8
Reviewed-on: https://go-review.googlesource.com/c/website/+/192329
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot