Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/content: TestContent missing Skip if 'go' binary is not found #33945

Closed
bcmills opened this issue Aug 29, 2019 · 1 comment
Closed

x/website/content: TestContent missing Skip if 'go' binary is not found #33945

bcmills opened this issue Aug 29, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2019

Seen on the 'illumos-amd64-joyent' builder, presumably because of an overly-narrow PATH setting (https://build.golang.org/log/08f6083e29377481efc89ed879146633dace2694):

--- FAIL: TestContent (0.01s)
    content_test.go:38: basics/basic-types.go: build error: exec: "go": executable file not found in $PATH
        output:
[…]
FAIL
FAIL	golang.org/x/tour/content	0.260s
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Aug 29, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2019
@bcmills bcmills mentioned this issue Aug 29, 2019
Open
@bcmills
Copy link
Contributor Author

bcmills commented Aug 29, 2019

Fixed in https://golang.org/cl/192328 (forgot to reference the issue there).

@bcmills bcmills closed this as completed Aug 29, 2019
@bcmills bcmills self-assigned this Aug 29, 2019
@golang golang locked and limited conversation to collaborators Aug 28, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot