New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/mobile: failed to compile a package with C in comments #33937
Comments
Ah, this was duplicated with #33859 |
I found this was another case. The error message starts with @matloob , any thoughts? |
Ugh, I think the best we can do is let through any errors that start with "# \n" the compiler can spit out arbitrary error messages and trying to parse them is hopeless |
Thanks,
This would highly likely include other messages than cgo, right? |
Unfortunately yes, but I think this is the best we can do. Long term, we need to fix go list -e to not print these errors to stderr. |
Change https://golang.org/cl/192330 mentions this issue: |
The latest version includes an issue: golang/go#33937
Change https://golang.org/cl/194497 mentions this issue: |
The latest x/tools includes the fix https://go-review.googlesource.com/c/tools/+/192330 for golang/go#33937. Updates golang/go#33937 Change-Id: I4af068315fb16aa3d526214f89e4005d792d0c49 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/194497 Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Build the below file with
gomobile bind -target=ios
What did you expect to see?
No error related to C compilation
What did you see instead?
At least 597adff16ade9d88626f8caea514bb189b8c74ee worked.
The text was updated successfully, but these errors were encountered: