Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: tests failing on Android builders #33935

Closed
bcmills opened this issue Aug 29, 2019 · 4 comments
Closed

x/website: tests failing on Android builders #33935

bcmills opened this issue Aug 29, 2019 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2019

Two tests seem to be consistently failing on the android-*-emu builders (https://build.golang.org/log/2b88b2f804799f9e5780270b06f07542b8c400ab):

-- FAIL: TestWeb (2.41s)
    godoc_test.go:48: Building godoc: exit status 1
FAIL
exitcode=1FAIL	golang.org/x/website/cmd/golangorg	68.529s
?   	golang.org/x/website/cmd/googlegolangorg	[no test files]
--- FAIL: TestStaticIsUpToDate (0.01s)
    gen_test.go:23: error while generating static.go: open analysis/call3.png: no such file or directory
    gen_test.go:27: static.go is stale.  Run:
          $ go generate golang.org/x/website/content/static
          $ git diff
        to see the differences.
FAIL
exitcode=1FAIL	golang.org/x/website/content/static	66.472s

We should either fix those tests, or (given that we're unlikely to be hosting golang.org on a mobile device any time soon) skip the x/mobile tests on those builders.

CC @toothrot @dmitshur @andybons
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. mobile Android, iOS, and x/mobile labels Aug 29, 2019
@bcmills bcmills added this to the Go1.13 milestone Aug 29, 2019
@dmitshur
Copy link
Contributor

TestStaticIsUpToDate is failing on that builder likely because it doesn't have local filesystem access. The test is passing on linux/amd64.

TestWeb is also failing on aix and illumos because it's unable to build or is missing the compiler.

I think it's reasonable to skip all these architectures for x/website tests.

@dmitshur dmitshur self-assigned this Aug 29, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Aug 29, 2019 •
edited

TestWeb is also failing on aix and illumos because it's unable to build or is missing the compiler.

If we disable the tests, these failures will become invisible. They fixable, so I'll leave them alone for now (and it's out of scope for this particular issue anyway).

@gopherbot
Copy link

Change https://golang.org/cl/192318 mentions this issue: dashboard: disable x/website tests on Android builders

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 29, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Aug 29, 2019 •
edited

Something that's odd is that buildGodoc is supposed to skip TestWeb when runtime.GOOS == "android". Is GOOS not "android" on android-*-emu builders?

Edit: Never mind, I was looking at x/tools. x/website's version of buildGodoc doesn't have the android skip:

https://github.com/golang/website/blob/d2d6abcea4890876ab16bfdea165af5cbac4cc0f/cmd/golangorg/godoc_test.go#L31

codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@dmitshur @codebien
dashboard: disable x/website tests on Android builders
3222335 
They don't have filesystem access implemented, nor can they compile
Go code (as currently done in golangorg tests).

x/website is sufficiently tested on many other architectures, and
it's more of an internal repository without plans to support mobile.

Fixes golang/go#33935

Change-Id: I6e3d06a72aeb865b9532fcf2dc699d8f180c0c2e
Reviewed-on: https://go-review.googlesource.com/c/build/+/192318
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot