Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: TestFormats failing in 'longtest' builder #33915

Closed
bcmills opened this issue Aug 28, 2019 · 2 comments
Closed

cmd/compile: TestFormats failing in 'longtest' builder #33915

bcmills opened this issue Aug 28, 2019 · 2 comments
Labels
FrozenDueToAge Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 28, 2019

Seen in https://build.golang.org/log/5d997ed9f7d7484f5ad245823d898de76948534e:

--- FAIL: TestFormats (4.21s)
    fmt_test.go:255: format map is out of date; run 'go test -u' to update and manually verify correctness of change'
FAIL
FAIL	cmd/compile	4.227s

Possible culprit CLs are:

CC @randall77
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Aug 28, 2019
@bcmills bcmills added this to the Go1.14 milestone Aug 28, 2019
@gopherbot
Copy link

Change https://golang.org/cl/192142 mentions this issue: cmd/compile: update fmt_test.go for esc.go code cleanup

tomocy pushed a commit to tomocy/go that referenced this issue Sep 1, 2019
@mdempsky @tomocy
cmd/compile: update fmt_test.go for esc.go code cleanup
c8a746e 
CL 187598 removed a bunch of esc.go's debug messages, so some format
strings are no longer needed.

Fixes golang#33915.

Change-Id: Iaadf12b5d68358e1abb00210f5aa8be01b36ce82
Reviewed-on: https://go-review.googlesource.com/c/go/+/192142
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@mdempsky @t4n6a1ka
cmd/compile: update fmt_test.go for esc.go code cleanup
b7f6d73 
CL 187598 removed a bunch of esc.go's debug messages, so some format
strings are no longer needed.

Fixes golang#33915.

Change-Id: Iaadf12b5d68358e1abb00210f5aa8be01b36ce82
Reviewed-on: https://go-review.googlesource.com/c/go/+/192142
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills bcmills mentioned this issue Oct 14, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/205440 mentions this issue: cmd/compile: do not skip TestFormats on short builders

pull bot pushed a commit to ksti/go that referenced this issue Nov 5, 2019
cmd/compile: do not skip TestFormats on short builders
9514914 
TestFormats adds ~3s of running time to the test, which may be
slightly annoying in an edit/compile/test cycle but is negligible in a
TryBot run.

The test keeps regressing in the longtest builders, requiring a manual
fix. Instead, run it even in short mode on the builders, so that
TryBot runs will detect regressions ahead of time.

Updates golang#34907
Updates golang#33915
Updates golang#28621

Change-Id: I6f9bf0f2ca929a743438310b86d85d8673c720bf
Reviewed-on: https://go-review.googlesource.com/c/go/+/205440
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@mdempsky @bcmills @gopherbot