Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportCancelRequestInDial failing since CL 185117 #33910

Closed
mvdan opened this issue Aug 28, 2019 · 2 comments
Closed

net/http: TestTransportCancelRequestInDial failing since CL 185117 #33910

mvdan opened this issue Aug 28, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@mvdan
Copy link
Member

mvdan commented Aug 28, 2019

https://build.golang.org/log/57ed2a1981079dd230a61ecbec0e7bdfa1e04fb3

--- FAIL: TestTransportCancelRequestInDial (0.00s)
    transport_test.go:2295: Got events:
        dial: blocking
        canceling
        Get = Get "http://something.no-network.tld/": net/http: request canceled while waiting for connection
        
        Want:
        dial: blocking
        canceling
        Get = Get http://something.no-network.tld/: net/http: request canceled while waiting for connection
FAIL
FAIL	net/http	41.278s
@mvdan mvdan added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 28, 2019
@mvdan mvdan self-assigned this Aug 28, 2019
@bcmills bcmills added Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. labels Aug 28, 2019
@bcmills bcmills added this to the Go1.14 milestone Aug 28, 2019
@mvdan
Copy link
Member Author

mvdan commented Aug 28, 2019

I have the (trivial) fix ready, but I'm running all tests to ensure no other failures remain.

@gopherbot
Copy link

Change https://golang.org/cl/192078 mentions this issue: net/http: fix a long test after CL 185117

tomocy pushed a commit to tomocy/go that referenced this issue Sep 1, 2019
@mvdan @tomocy
net/http: fix a long test after CL 185117
199e310 
The net/url error in question now quotes the URL, so update the expected
output string.

While at it, also update a comment in httputil, though that doesn't
affect any test.

Fixes golang#33910.

Change-Id: I0981f528b24337c2952ef60c0db3b7ff72d72110
Reviewed-on: https://go-review.googlesource.com/c/go/+/192078
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@mvdan @t4n6a1ka
net/http: fix a long test after CL 185117
9d640e1 
The net/url error in question now quotes the URL, so update the expected
output string.

While at it, also update a comment in httputil, though that doesn't
affect any test.

Fixes golang#33910.

Change-Id: I0981f528b24337c2952ef60c0db3b7ff72d72110
Reviewed-on: https://go-review.googlesource.com/c/go/+/192078
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Aug 27, 2020
@rsc rsc unassigned mvdan Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@mvdan @bcmills @gopherbot