Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: one new module error is backwards, another seemed backwards [1.13 backport] #33885

Closed
gopherbot opened this issue Aug 27, 2019 · 3 comments
Closed

cmd/go: one new module error is backwards, another seemed backwards [1.13 backport] #33885

gopherbot opened this issue Aug 27, 2019 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.13

Comments

@gopherbot
Copy link

@bcmills requested issue #33879 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13: we should at least fix the reversed error message.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 27, 2019
@gopherbot gopherbot mentioned this issue Aug 27, 2019
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/191972 mentions this issue: [release-branch.go1.13] cmd/go/internal/modload: fix swapped paths in error message

@bcmills bcmills added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 27, 2019
@bcmills bcmills added this to the Go1.13 milestone Aug 27, 2019
@bcmills
Copy link
Contributor

bcmills commented Aug 27, 2019

I'm not sure whether this is severe enough to make the cut.
Making that decision is a release-blocker, but actually cherry-picking the commit probably is not.

@bcmills bcmills added release-blocker CherryPickApproved Used during the release process for point releases labels Aug 27, 2019
gopherbot pushed a commit that referenced this issue Aug 27, 2019
[release-branch.go1.13] cmd/go/internal/modload: fix swapped paths in…
1ae4e73 
… error message

Cherry-picked from CL 191997.

Updates #33879
Fixes #33885

Change-Id: Ifc91490b1cb791fdf5ffe69ef81c0ec0e6cbecc3
Reviewed-on: https://go-review.googlesource.com/c/go/+/191997
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
(cherry picked from commit 8f5353f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191972
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bcmills bcmills removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Aug 27, 2019
@bcmills
Copy link
Contributor

bcmills commented Aug 27, 2019

The fix for the swapped paths has been merged.

@bcmills bcmills closed this as completed Aug 27, 2019
@bcmills bcmills removed the CherryPickCandidate Used during the release process for point releases label Aug 27, 2019
@golang golang locked and limited conversation to collaborators Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
2 participants
@bcmills @gopherbot