Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: test prompts to authenticate vcs-test.golang.org #33883

Closed
bcmills opened this issue Aug 27, 2019 · 5 comments
Closed

cmd/go: test prompts to authenticate vcs-test.golang.org #33883

bcmills opened this issue Aug 27, 2019 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 27, 2019

When running go test cmd/go/... for the first time on a new machine, I saw an ssh prompt on the terminal:

The authenticity of host 'vcs-test.golang.org (35.184.38.56)' can't be established.
ECDSA key fingerprint is SHA256:[…].
Are you sure you want to continue connecting (yes/no)? yes

Perhaps we can add a known_hosts file somewhere in cmd/go/testdata and set some environment variable to suppress the prompt?

(See also #27494.)

CC @hanwen @FiloSottile @jayconrod
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. labels Aug 27, 2019
@bcmills bcmills added this to the Go1.14 milestone Aug 27, 2019
@hanwen
Copy link
Contributor

hanwen commented Aug 28, 2019

prompt looks as if it comes from openssh and not Go SSH, so unsubscribing.

@mvdan
Copy link
Member

mvdan commented Aug 28, 2019

I encountered the same, and it was pretty annoying as it stopped a long-running go test std cmd check until I went to appease openssh :)

@mvdan
Copy link
Member

mvdan commented Oct 5, 2019

This is annoying me again, enough to investigate a bit. I narrowed it down to TestScript/mod_get_svn.

There is a way to give ssh a flag to skip this verification, but unfortunately that knob can't be turned via an environment variable.

Worse even, ssh doesn't obey $HOME, so I can't use that to point it at a different config or known_hosts file.

@mvdan
Copy link
Member

mvdan commented Oct 5, 2019

I found a workaround hack for it. It isn't great, but it's better than not having a workaround.

@gopherbot
Copy link

Change https://golang.org/cl/199142 mentions this issue: cmd/go: avoid ssh known_hosts prompts on test

@mvdan mvdan mentioned this issue Oct 10, 2019
Closed
@golang golang locked and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@hanwen @mvdan @bcmills @gopherbot