Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestAccidentalGitCheckout spuriously fails if 'git' is installed but 'svn' is not #33881

Closed
bcmills opened this issue Aug 27, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 27, 2019

bcmills@dev-bcmills-ubuntu16:~/go/src$ go version
go version devel +7495087 Tue Aug 27 14:18:48 2019 -0400 linux/amd64

bcmills@dev-bcmills-ubuntu16:~/go/src$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/bcmills/.cache/go-build"
GOENV="/home/bcmills/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/bcmills"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/bcmills/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/bcmills/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/home/bcmills/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build421259110=/tmp/go-build -gno-record-gcc-switches"

Spotted when running go test cmd/go/... on an Ubuntu 16.04 VM:

--- FAIL: TestAccidentalGitCheckout (0.88s)
    go_test.go:1385: running testgo [get -u vcs-test.golang.org/go/test1-svn-git]
    go_test.go:1385: standard error:
    go_test.go:1385: go: missing Subversion command. See https://golang.org/s/gogetcmd
        package vcs-test.golang.org/go/test1-svn-git: exec: "svn": executable file not found in $PATH

    go_test.go:1385: testgo failed as expected: exit status 1
    go_test.go:1386: get did not fail for right reason
    go_test.go:1386: pattern src[\\/]vcs-test.* uses git, but parent .*src[\\/]vcs-test.* uses svn not found in standard error
FAIL
FAIL    cmd/go  298.517s
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Aug 27, 2019
@bcmills bcmills added this to the Go1.14 milestone Aug 27, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@ALTree
Copy link
Member

ALTree commented Jul 20, 2020

This was fixed in c6bcdea. Closing here.

@ALTree ALTree closed this as completed Jul 20, 2020
@golang golang locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants