Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/url: TestParseErrors failing on all builders #33875

Closed
ALTree opened this issue Aug 27, 2019 · 3 comments
Closed

net/url: TestParseErrors failing on all builders #33875

ALTree opened this issue Aug 27, 2019 · 3 comments
Labels
FrozenDueToAge

Comments

@ALTree
Copy link
Member

ALTree commented Aug 27, 2019 •
edited

TestParseErrors is currently failing on all builders: https://build.golang.org

--- FAIL: TestParseErrors (0.00s)
    url_test.go:1459: Parse("mysql://x@y(z:123)/foo") = parse mysql://x@y(z:123)/foo: invalid port ":123)" after host; want no error
    url_test.go:1459: Parse("mysql://x@y(1.2.3.4:123)/foo") = parse mysql://x@y(1.2.3.4:123)/foo: invalid port ":123)" after host; want no error
FAIL
FAIL	net/url	0.007s
FAIL

Failures started by https://go-review.googlesource.com/c/go/+/185080
@ALTree
Copy link
Member Author

ALTree commented Aug 27, 2019

Reverted : )

@ALTree ALTree closed this as completed Aug 27, 2019
@av86743
Copy link

av86743 commented Aug 27, 2019

Why bots did not fail back in August?

@av86743 av86743 mentioned this issue Aug 27, 2019
Closed
@av86743
Copy link

av86743 commented Aug 27, 2019

Root cause: Process flaw.

Commit CL#185080 was not verified immediately before being merged. While at the time of merge, test expectations have changed as a result of other commits, making this commit to fail.

@av86743 av86743 mentioned this issue Aug 28, 2019
Closed
@golang golang locked and limited conversation to collaborators Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@av86743 @ALTree @gopherbot