Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gccgo: ICE in write_specific_type_functions on anon imported struct type #33866

Closed
thanm opened this issue Aug 27, 2019 · 2 comments
Closed

gccgo: ICE in write_specific_type_functions on anon imported struct type #33866

thanm opened this issue Aug 27, 2019 · 2 comments
Labels
FrozenDueToAge
Milestone
Gccgo

Comments

@thanm
Copy link
Contributor

thanm commented Aug 27, 2019

What version of Go are you using (go version)?

Using gccgo tip, linux/amd64.

$ go version
go version go1.12.2 gccgo (GCC) 10.0.0 20190822 (experimental) linux/amd64

Does this issue reproduce with the latest release?

Yes.

What did you do?

Build these two packages:

Package a.go:

package a

type Builder struct {
	x int
}

func (tb Builder) Build() (out struct {
	x interface{}
	s string
}) {
	out.x = nil
	out.s = "hello!"
	return
}

Package b.go:

package b

import "a"

type (
	ABuilder = a.Builder
)

func Bfunc() ABuilder {
	return ABuilder{}
}

What did you expect to see?

Clean build.

What did you see instead?

Compiling b.go triggers this assert:

$ go build .
# b
go1: internal compiler error: in write_specific_type_functions, at go/gofrontend/types.cc:2074
0x66feb0 Type::write_specific_type_functions(Gogo*, Named_type*, long, std::__cxx11::basic_string, std::allocator > const&, Function_type*, std::__cxx11::basic_string, std::allocator > const&, Function_type*)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:2074
0x9046b2 Type::specific_type_functions(Gogo*, Named_type*, long, Function_type*, Function_type*, Named_object**, Named_object**)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:2050
0x903015 Type::type_functions(Gogo*, Named_type*, Function_type*, Function_type*, Named_object**, Named_object**)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:1955
0x907290 Type::type_descriptor_constructor(Gogo*, int, Named_type*, Methods const*, bool)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:2450
0x908108 Struct_type::do_type_descriptor(Gogo*, Named_type*)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:6380
0x9001c2 Type::make_type_descriptor_var(Gogo*)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:1359
0x9003ef Type::type_descriptor_pointer(Gogo*, Location)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:1290
0x86e388 Array_construction_expression::get_constructor(Translate_context*, Btype*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:15200
0x8682aa Unary_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:4980
0x856f55 Unsafe_type_conversion_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:4322
0x857529 Slice_value_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:17456
0x86e1ac Struct_construction_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:14924
0x900030 Type::make_type_descriptor_var(Gogo*)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:1410
0x9003ef Type::type_descriptor_pointer(Gogo*, Location)
	../../gcc-trunk/gcc/go/gofrontend/types.cc:1290
0x870c1b Type_conversion_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:4112
0x86e1ac Struct_construction_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:14924
0x86e388 Array_construction_expression::get_constructor(Translate_context*, Btype*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:15200
0x8682aa Unary_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:4980
0x856f55 Unsafe_type_conversion_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:4322
0x857529 Slice_value_expression::do_get_backend(Translate_context*)
	../../gcc-trunk/gcc/go/gofrontend/expressions.cc:17456

The type triggering the assert is the anonymous struct that forms the type of the "out" param on the builder method defined in a.go. It appears that when compiling b.go the walk used to find types that need type-specific functions isn't discovering this type.
@gopherbot gopherbot added this to the Gccgo milestone Aug 27, 2019
@thanm thanm self-assigned this Aug 27, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/191961 mentions this issue: compiler: suppress type descriptor for local alias of external type

gopherbot pushed a commit to protocolbuffers/protobuf-go that referenced this issue Aug 27, 2019
@neild
internal/filetype, internal/filedesc: avoid gccgo bug
95758c0 
Returning an anonymous struct is tickling a gccgo bug:
golang/go#33866

Change to a named type. We could make the type unexpoerted, but this is
an internal package anyway so leave it exported for general style
cleanliness.

Change-Id: Idf33f1e354c0e07066ab68640308af1498a01447
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/191960
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/193261 mentions this issue: test: new testcase

gopherbot pushed a commit that referenced this issue Sep 6, 2019
@thanm
test: add test that failed with gccgo
d4a6a26 
Test with some code that triggered a compilation error bug in gccgo.

Updates #33866.

Change-Id: Ib2f226bbbebbfae33b41037438fe34dc5f2ad034
Reviewed-on: https://go-review.googlesource.com/c/go/+/193261
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Sep 10, 2020
asiekierka pushed a commit to WonderfulToolchain/gcc-ia16 that referenced this issue May 16, 2022
compiler: suppress type descriptor generation for aliases
a387d63 
    
    Change Named_object::get_backend to ignore aliases when creating type
    descriptors for types, to be consistent with
    Type::needs_specific_type_functions and the Specific_type_functions
    traversal class. For example, when compiling a package that creates an
    alias to an an externally defined type, e.g.
    
       import "foo"
       type MyFoo = foo.Foo
    
    it makes sense to skip the alias (not try to generate type specific
    functions for it) and let the normal mechanisms take care of the alias
    target, depending on whether the target is defined locally or defined
    elsewhere.
    
    Testcase for this problen can be found in CL 193261.
    
    Fixes golang/go#33866.
    
    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/191961

From-SVN: r275651
@rsc rsc unassigned thanm Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Gccgo
Development

No branches or pull requests
2 participants
@gopherbot @thanm