Comment 1:

Labels changed: added priority-later, removed priority-triage.

Owner changed to @griesemer.

Status changed to Accepted.

Comment 2:

Labels changed: added go1.1maybe.

Comment 4:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

Comment 5:

Labels changed: added godoc.

Comment 6:

Using the fsnotify package (go.exp/fsnotify) to solve this issue is probably the
preferred way. If so issue #4068 should be marked as a blocker for this issue.

Comment 7:

Labels changed: added go1.3maybe.

Comment 8:

Labels changed: added release-none, removed go1.3maybe.

Comment 9:

Labels changed: added repo-tools.

Comment 10:

Owner changed to bgarcia@golang.org.

Comment 11 by bgarcia@golang.org:

I see that Corpus.RunIndexer() should periodically update the index.
https://code.google.com/p/go/source/browse/godoc/index.go?repo=tools#1477
But digging a little deeper, I find that it will only reindex after
Corpus.invalidateIndex is called.  And that is only called once, from Corpus.Init.  So
it would seem that the infinite loop within Corpus.RunIndexer will do something once, at
startup, but then never do anything again.
Is there another code path that I'm missing?  How do people feel about re-indexing
unconditionally every Corpus.IndexInterval?

Comment 12:

I think the plan is to use fsnotify to solve this issue. The proposal is located at:
https://docs.google.com/document/d/1xl_aRcCbksFRmCKtoyRQG9L7j6DIdMZtrkFAoi5EXaA/edit?pli=1

Comment 13 by bgarcia@google.com:

In the meantime, it appears that the Corpus.RunIndexer loop serves no purpose.  We
should either exit that loop after updating the index, or just periodically re-index
unconditionally.
Or, does that loop serve another purpose that I'm just not seeing?

Comment 14 by bgarcia@golang.org:

In the meantime, it appears that the Corpus.RunIndexer loop serves no purpose.  We
should either exit that loop after updating the index, or just periodically re-index
unconditionally.
Or, does that loop serve another purpose that I'm just not seeing?

Comment 15 by bgarcia@golang.org:

Short-term fix has been submitted:
https://code.google.com/p/go/source/detail?r=2e2c0a636a58&repo=tools
This will unconditionally re-index periodically.
Leaving this issue unresolved for a permanent fix that makes use of fsnotify when it's
ready.

Labels changed: added release-go1.3maybe, removed release-none.

Comment 16:

Labels changed: added suggested, removed release-go1.3maybe.

Comment 17:

Labels changed: added release-none.

This was decided in #7524 that it is enough to be able to tune the index interval to have enough control to change the update frequency. Mentioning here for reference -

@andybons- Another alternative--though I'm not saying it's a good one--is to allow a flag to specify how often to index or to disable reindexing entirely. It's unclear what's better here. Whether to add yet another flag or increase the complexity of the code by adding inotify watches.

@agnivade- It is already behind a flag called "index", which is false by default. And the index_interval is also behind a flag (default of 5 mins).

@andybons- Then let’s close this. If it comes up again we can revisit.

Hence, closing this.