-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/mail: ReadMessage fails on header-only messages #33823
Comments
CC @bradfitz (on leave) |
Can confirm header-only messages are valid messages. (For reference, here's a similar patch for go-message: https://lists.sr.ht/~emersion/public-inbox/patches/9396) |
Fixing (Unfortunately Anyway, |
I also experience this issue. See also some related issue in #53858 |
Change https://go.dev/cl/344269 mentions this issue: |
Sorry to open this again (see #15632, #24256).
Postfix just landed one such message on my Maildir mailbox, and my Go tools choked on it.
(I receive messages one per file, in raw format, with LF line endings from Postfix.)
The message has no body and only one LF at the end. The
X-Mailer
header field saysMIME-tools 5.503 (Entity 5.501)
. It was sent by a person.You can see it here (slightly altered).
Isn't it standard compliant?
According to RFC 5322 it seems that the body is optional and the empty line is required only if the body is present:
And such
message
is whatmail.ReadMessage
should be able to parse.Postfix can send header-only messages, and it preserves the absence of the empty line.
To reproduce it, setup Postfix to deliver to a Maildir mailbox, then send yourself a header-only message using the
sendmail
command.(If you use an mbox mailbox you get multiple messages per file, and an empty line is added as a separator, in addition to the "From_ line", but an mbox is not a message.)
I agree that header-only messages are rare and not very useful and this is a minor issue, but not completely worthless.
The simplest solution would be to filter out
EOF
inmail.ReadMessage
here. But that would make it succeed even in case of incomplete last line (possibly truncated message).The text was updated successfully, but these errors were encountered: