Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/releasebot: don't print "The release is ready." on failure #33764

Closed
smasher164 opened this issue Aug 21, 2019 · 1 comment
Closed

x/build/cmd/releasebot: don't print "The release is ready." on failure #33764

smasher164 opened this issue Aug 21, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@smasher164
Copy link
Member

Some of the logs in #33760 send a conflicting message when they print "The release is ready." even with build and test failures. My guess is that in build/main.go#L340, len(w.Errors) needs to be checked and error out.
@smasher164 smasher164 added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 21, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2019
@dmitshur dmitshur self-assigned this Aug 21, 2019
@gopherbot
Copy link

Change https://golang.org/cl/191162 mentions this issue: cmd/releasebot: make problems with release easier to see

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 21, 2019
@dmitshur dmitshur changed the title x/cmd/build/releasebot: don't print "The release is ready." on failure x/build/cmd/releasebot: don't print "The release is ready." on failure Aug 21, 2019
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@dmitshur @codebien
cmd/releasebot: make problems with release easier to see
8f805d7 
If the build releases step fails, stop there, instead of proceeding
or printing misleading next steps. Those next steps apply only after
the build releases step succeeds.

Also add a sentence at the end of the GitHub comment posted on the
release issue when there was a problem, so it's easier to see.

Fixes golang/go#33764
Updates golang/go#33760

Change-Id: Ice9ef155cd64173a2f48f96efc809634628d9165
Reviewed-on: https://go-review.googlesource.com/c/build/+/191162
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @smasher164