Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build, cmd/go: TestGoGetInsecure failing in release-branch.go1.12 #33758

Closed
bcmills opened this issue Aug 21, 2019 · 2 comments
Closed

x/build, cmd/go: TestGoGetInsecure failing in release-branch.go1.12 #33758

bcmills opened this issue Aug 21, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12.12

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 21, 2019 •
edited

TestGoGetInsecure in cmd/go is currently failing in the linux-amd64-longtest builder on release-branch.go1.12 (https://build.golang.org/log/01102088d2b8610a921c538f1beb335acb222c51):

--- FAIL: TestGoGetInsecure (14.49s)
    --- FAIL: TestGoGetInsecure/modules (4.12s)
        go_test.go:3650: running testgo [get -d insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:3650: standard error:
        go_test.go:3650: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unexpected status (http://10.240.0.55:30157/insecure.go-get-issue-15410.appspot.com/pkg/p/@v/list): 410 Gone
            
        go_test.go:3650: testgo failed as expected: exit status 1
        go_test.go:3653: running testgo [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p]
        go_test.go:3653: standard error:
        go_test.go:3653: go get insecure.go-get-issue-15410.appspot.com/pkg/p: unexpected status (http://10.240.0.55:30157/insecure.go-get-issue-15410.appspot.com/pkg/p/@v/list): 410 Gone
            
        go_test.go:3653: go [get -d -insecure insecure.go-get-issue-15410.appspot.com/pkg/p] failed unexpectedly in /workdir/tmp/gotest754988467: exit status 1
        panic.go:406: ended in /workdir/tmp/gotest754988467

The failure seems to have something to do with a local proxy running on the builder, possibly from #31770 or #14594.

Probably we just need to backport https://golang.org/cl/165745 and https://golang.org/cl/167086 to clear GOPROXY for the test (#30571).
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 21, 2019
@bcmills bcmills modified the milestones: Unreleased, Go1.12.10 Aug 21, 2019
@bcmills bcmills added release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. labels Aug 21, 2019
@bcmills bcmills self-assigned this Aug 21, 2019
@FiloSottile FiloSottile modified the milestones: Go1.12.10, Go1.12.11 Sep 25, 2019
@FiloSottile FiloSottile added the CherryPickApproved Used during the release process for point releases label Oct 8, 2019
@FiloSottile FiloSottile assigned katiehockman and unassigned bcmills Oct 8, 2019
@gopherbot
Copy link

Change https://golang.org/cl/199820 mentions this issue: [release-branch.go1.12] cmd/go: clear GOPROXY in TestGoGetInsecure

@gopherbot
Copy link

Closed by merging d7dd91a to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Oct 8, 2019
@FiloSottile
[release-branch.go1.12] cmd/go: clear GOPROXY in TestGoGetInsecure
d7dd91a 
TestGoGetInsecure verifies that 'go get -insecure' can fetch a
particular package. However, the GOPROXY protocol does not provide a
means for proxies to indicate packages as insecure; thus, proxies
cannot safely serve those packages.

This also squashes the typo fix from CL 167086.

Updates #30571
Fixes #33758

Change-Id: I447776dff98bd8ee6eb5055b897b9c7d293e3423
Reviewed-on: https://go-review.googlesource.com/c/go/+/165745
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/199820
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12.12
Development

No branches or pull requests
4 participants
@FiloSottile @bcmills @gopherbot @katiehockman