-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build, runtime: linux-s390x-ibm regression in TestGdbPython on release-branch.go1.12 #33757
Comments
linux-s390x-ibm
regression in on release-branch.go1.12
I suspect that the build started failing when I installed GDB on the builder following the merge of https://golang.org/cl/169857 into master. We could cherry-pick that fix I guess. Or disable the test somehow. |
Either of those options seems reasonable to me, assuming the merge is clean. CC @cherrymui |
SGTM as well. Thanks. |
This is a fix that addresses an external change that would otherwise make the release unstable with failing tests, so approved the cherry pick. I'll make the CL now. |
Change https://golang.org/cl/200039 mentions this issue: |
Closed by merging df92229 to release-branch.go1.12. |
On Ubuntu 18.04 I am seeing GDB fail to restore the stack pointer during this test because stack unwinding can't find the PC. This CL is essentially a partial revert of CL 23940 and fixes the issue on s390x. Fixes #33757 Change-Id: Ib4c41162dc85dc882eb6e248330f4082c3fa94c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/169857 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> (cherry picked from commit d91f7e6) Reviewed-on: https://go-review.googlesource.com/c/go/+/200039 Run-TryBot: Katie Hockman <katie@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Michael Munday <mike.munday@ibm.com>
TestGdbPython
(in theruntime
package) has been failing on thelinux-s390x-ibm
builder onrelease-branch.go1.12
starting at CL 181658 (https://build.golang.org/log/c9c6830fd79bda38aa4a7c5f1594aafccda247cb).The failure mode appears to be unrelated to that change, so I'm guessing that something about the builder configuration may have changed..?
CC @mundaym @aclements
The text was updated successfully, but these errors were encountered: