Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: RPC logging is incorrect #33755

Closed
pjweinb opened this issue Aug 21, 2019 · 2 comments
Closed

x/tools/gopls: RPC logging is incorrect #33755

pjweinb opened this issue Aug 21, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@pjweinb
Copy link

pjweinb commented Aug 21, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.5 linux/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
linux
The first two records output are out of order. [Trace - 10:04:01 AM] Received response 'initialize - (0)' in 0ms. is the response to the initialize request, and the second log record [Trace - 10:04:01 AM] Sending notification 'initialize' in 85ms. is not a notification, but (from looking at the content) the initialization request.

Then the next two log entries are doubly out of order:
[Trace - 10:04:01 AM] Sending response 'client/registerCapability - (1)' in 0ms.
Params: {}

[Trace - 10:04:01 AM] Received notification 'client/registerCapability' in 2ms.
Params: {"registrations":[{"id":"workspace/didChangeConfiguration","method":"workspace/didChangeConfiguration"},{"id":"workspace/didChangeWorkspaceFolders","method":"workspace/didChangeWorkspaceFolders"}]}

as they actually happened (on the wire) after the client notified the server that it was initialized.
[as shown by added code in headerStream.Read/headerStream.Write that dumps data just as it is read or written.
@gopherbot gopherbot added this to the Unreleased milestone Aug 21, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Aug 21, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting section of the gopls Wiki page, and make sure that you have provided all of the relevant information here.

@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 24, 2019
@gopherbot
Copy link

Change https://golang.org/cl/191963 mentions this issue: x/tools/gopls: reimplement rpc logging at a lower level

@golang golang locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@pjweinb @stamblerre @gopherbot