Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strconv: ParseFloat, ParseInt, ParseUint docs don't show that they accept underscores to group digits #33750

Closed
odeke-em opened this issue Aug 21, 2019 · 2 comments
Closed

strconv: ParseFloat, ParseInt, ParseUint docs don't show that they accept underscores to group digits #33750

odeke-em opened this issue Aug 21, 2019 · 2 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.13

Comments

@odeke-em
Copy link
Member

We added support for underscores to group digits as per Go 2 language changes for strconv in 36a81d5#diff-15cb26824bae5fecc60070ada211e995 aka CL https://go-review.googlesource.com/c/160243
but unfortunately we didn't update the docs
as per

I noticed this while working on CL https://go-review.googlesource.com/c/go/+/191077
@odeke-em odeke-em self-assigned this Aug 21, 2019
@odeke-em odeke-em added this to the Go1.13 milestone Aug 21, 2019
@gopherbot
Copy link

Change https://golang.org/cl/191078 mentions this issue: strconv: document _ grouping in digits for Parse(Float, *Int)

@gopherbot
Copy link

Change https://golang.org/cl/191168 mentions this issue: [release-branch.go1.13] strconv: update documentation

gopherbot pushed a commit that referenced this issue Aug 22, 2019
@odeke-em @andybons
[release-branch.go1.13] strconv: update documentation
bd2e281 
Fixes #33750.
Updates #31197.

Change-Id: I26f63cef57e5f0eec85b84554c82f6d47b4f41a1
Reviewed-on: https://go-review.googlesource.com/c/go/+/191078
Reviewed-by: Robert Griesemer <gri@golang.org>
(cherry picked from commit d9b1323)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191168
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@odeke-em @t4n6a1ka
strconv: update documentation
1e7c7ab 
Fixes golang#33750.
Updates golang#31197.

Change-Id: I26f63cef57e5f0eec85b84554c82f6d47b4f41a1
Reviewed-on: https://go-review.googlesource.com/c/go/+/191078
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
2 participants
@odeke-em @gopherbot