Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: do not embed style in release-note HTML files #33738

Open
tomocy opened this issue Aug 20, 2019 · 7 comments
Open

doc: do not embed style in release-note HTML files #33738

tomocy opened this issue Aug 20, 2019 · 7 comments
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@tomocy
Copy link
Contributor

tomocy commented Aug 20, 2019

When styles are embedded in release note html files, it may also require you to do the same thing in the previous ones to keep the same style across all versions.

The embedded style in go1.6 html seems to cause #33718.

I think that it is better to try not to embed style in release note html files, and write it in stylesheet instead.
@bcmills bcmills changed the title doc: not to embed style in release note html files doc: do not embed style in release-note HTML files Aug 20, 2019
@bcmills
Copy link
Contributor

bcmills commented Aug 20, 2019

CC @andybons

@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 20, 2019
@bcmills bcmills added this to the Go1.14 milestone Aug 20, 2019
@andybons
Copy link
Member

Let's just do this instead of #33718

@andybons andybons mentioned this issue Aug 21, 2019
Closed
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 21, 2019
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 21, 2019
@gopherbot
Copy link

Change https://golang.org/cl/191217 mentions this issue: doc: remove embed style in release-note HTML files

@bcmills bcmills mentioned this issue Aug 26, 2019
Closed
gopherbot pushed a commit that referenced this issue Aug 26, 2019
@obeis @andybons
doc: align documents link
cded9f4 
Updates #33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/191747 mentions this issue: [release-branch.go1.13] doc: align documents link

@gopherbot
Copy link

Change https://golang.org/cl/191748 mentions this issue: [release-branch.go1.12] doc: align documents link

gopherbot pushed a commit that referenced this issue Aug 26, 2019
@obeis @andybons
[release-branch.go1.12] doc: align documents link
61a5d11 
Updates #33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit cded9f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191748
Reviewed-by: Katie Hockman <katie@golang.org>
gopherbot pushed a commit that referenced this issue Aug 26, 2019
@obeis @andybons
[release-branch.go1.13] doc: align documents link
994ebd3 
Updates #33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit cded9f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/191747
Reviewed-by: Katie Hockman <katie@golang.org>
tomocy pushed a commit to tomocy/go that referenced this issue Sep 1, 2019
@obeis @tomocy
doc: align documents link
47c67a6 
Updates golang#33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@obeis @t4n6a1ka
doc: align documents link
880c088 
Updates golang#33738

Change-Id: If0856d7c57ecfde08341c1aecb5e92361fd64f2b
Reviewed-on: https://go-review.googlesource.com/c/go/+/191217
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/195058 mentions this issue: doc/go1.13: start doc; note end of NaCl platform support

gopherbot pushed a commit that referenced this issue Sep 12, 2019
doc/go1.14: start doc; note end of NaCl platform support
a9fdd6b 
This skeleton follows the model of CL 174521,
with additions from 'relnote -html'.

Updates #33738
Updates #30439

Change-Id: I0f88ff7f231b7728dca0695143f2f2eda74d60c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/195058
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot
Copy link

Change https://golang.org/cl/220278 mentions this issue: doc/go1.15: create go1.15.html

gopherbot pushed a commit that referenced this issue Feb 20, 2020
doc/go1.15: create go1.15.html
a682cba 
Copied from go1.14.html, with changes redacted back to TODOs following
the model of CL 195058.

'relnote -html' does not report any changes at this time.

Updates #33738

Change-Id: I580232805ab7db35935f3e1ba03b720be4796a7e
Reviewed-on: https://go-review.googlesource.com/c/go/+/220278
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@rsc @andybons @bcmills @gopherbot @tomocy