-
Notifications
You must be signed in to change notification settings - Fork 18k
x/website: documents link is not aligned on tip.golang.org/doc/go1.6+ #33718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ah, that's funny. In the Go1.5 page and before they're aligned. The issue is caused by an embedded style
in the .html page, that is present since the Go1.6 release notes. |
Can I tackle on this? |
@tomocy Sure. If you do, please double-check that my analysis above is correct. I just skimmed the pages sources very quickly. |
@ALTree FYI that rule is overwritten by line 429 of style.css, so that is not the issue. And in general its weird that ALL other pages work as expected. |
@ALTree I want to modify |
https://github.com/golang/website/blob/master/content/static/style.css EDIT: In general, the title prefix is the package name from the standard library or anything under golang.org. In this case, it is x/website, so golang.org/x/website. That is how you can find which repo holds the code for this issue. |
@agnivade Thank you!! (I did not know website repo) |
Since the doc of go1.6, the default margin-top of list tag has been 0.5rem not 0 by the embedded style, so assert the same style as the embedded style in stylesheet and re-set the default margin-top to the first of Header-menuItem overwriting the margin-top of it in no media queries. Fixes golang/go#33718
Change https://golang.org/cl/190997 mentions this issue: |
Duplicate of #33738 |
What did you do?
visit one of:
https://tip.golang.org/doc/go1.6
...
https://tip.golang.org/doc/go1.13
What did you expect to see?
see behavior on everything pre go1.6 docs
What did you see instead?
The text was updated successfully, but these errors were encountered: