cmd/compile: new escape analysis implementation doesn't heap-allocate pointer #33662
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
release-blocker
Soon
This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Apache Beam has a function as follows:
When compiled on Go1.12 with
-gcflags=-m
, we see:When compiled on Go1.13 with
-gcflags=-m
, the fact that&ptr
escapes is no longer true. The effect of this change is a subtle memory corruption where since&ptr
now points to the heap, rather than a copy of the value on the stack.Git bisect reports that the issue is due to CL/170448, which seems to suggest that this breakage is intentional. The fix the Beam code is relatively straight forward by manually allocating
ptr
on the heap.I'm filing an issue to confirm that this is an expected regression.
\cc @mdempsky @dr2chase
The text was updated successfully, but these errors were encountered: