Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: CSS breakpoint in nav is wrong #33652

Closed
julieqiu opened this issue Aug 14, 2019 · 3 comments
Closed

x/website: CSS breakpoint in nav is wrong #33652

julieqiu opened this issue Aug 14, 2019 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

Only the bottom half of the Go logo is visible when resizing the browser, somewhere between Desktop and mobile sizes.

image

/cc @andybons
@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 14, 2019
@julieqiu julieqiu added this to the Unreleased milestone Aug 14, 2019
@andybons andybons changed the title x/website: minor CSS issue in nav x/website: CSS breakpoint in nav is wrong Aug 14, 2019
@gopherbot
Copy link

Change https://golang.org/cl/190408 mentions this issue: content/static: apply various stylistic fixes

@andybons
Copy link
Member

Fix does not take into account scrollbars

@andybons andybons reopened this Aug 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/190413 mentions this issue: content/status: account for vertical scrollbar in nav breakpoint

@golang golang locked and limited conversation to collaborators Aug 14, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: apply various stylistic fixes
1150a95 
+ Adjust the breakpoint in the header nav so that the text
  doesn't overflow at certain widths
+ Change h1-h4 elements to be Work Sans
+ Add a top margin to the footer to give it more space

Fixes golang/go#33638
Fixes golang/go#33652

Change-Id: I60567a6edbb3ddc42333b646b5127d8c328d3712
Reviewed-on: https://go-review.googlesource.com/c/website/+/190408
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/status: account for vertical scrollbar in nav breakpoint
11458de 
Fixes golang/go#33652

Change-Id: Ibcc6a6f29ef3deb1b93ea89be3e282df6e82c391
Reviewed-on: https://go-review.googlesource.com/c/website/+/190413
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @julieqiu @gopherbot