Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing/iotest: there are no tests for the package #33650

Closed
psampaz opened this issue Aug 14, 2019 · 1 comment
Closed

testing/iotest: there are no tests for the package #33650

psampaz opened this issue Aug 14, 2019 · 1 comment
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unplanned

Comments

@psampaz
Copy link
Contributor

psampaz commented Aug 14, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.7 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/ps/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/ps/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build253106191=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Tried to run tests for the iotest package

What did you expect to see?

A test suite and a high coverage

What did you see instead?

No tests
@psampaz psampaz mentioned this issue Aug 14, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/190259 mentions this issue: testing/iotest: add tests for reader

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Aug 14, 2019
@andybons andybons added this to the Unplanned milestone Aug 14, 2019
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 15, 2019
@golang golang locked and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unplanned
Development

Successfully merging a pull request may close this issue.

testing/iotest: add missing tests psampaz/go
4 participants
@andybons @psampaz @bcmills @gopherbot