You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new website's footer could use extra spacing (and/or a visual separator such as a line or a different background color) to differentiate it from the body.
Right now the spacing depends on the preceding element, so it varies from page to page.
For these two pages, the spacing isn't too bad, but I think it's not enough: the footer looks like part of the page content rather than something different.
I'm using Chrome 76.0.3809.100 on Linux but it looks roughly the same in Firefox and on an Android phone (if I request desktop site). I don't think this is a browser-specific issue.
katiehockman
added
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
and removed
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
labels
Aug 14, 2019
+ Adjust the breakpoint in the header nav so that the text
doesn't overflow at certain widths
+ Change h1-h4 elements to be Work Sans
+ Add a top margin to the footer to give it more space
Fixesgolang/go#33638Fixesgolang/go#33652
Change-Id: I60567a6edbb3ddc42333b646b5127d8c328d3712
Reviewed-on: https://go-review.googlesource.com/c/website/+/190408
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The new website's footer could use extra spacing (and/or a visual separator such as a line or a different background color) to differentiate it from the body.
Right now the spacing depends on the preceding element, so it varies from page to page.
For these two pages, the spacing isn't too bad, but I think it's not enough: the footer looks like part of the page content rather than something different.
https://golang.org/pkg/archive/zip/:
https://blog.golang.org/experiment:
On this page, the spacing is more clearly insufficient and the footer crowds into the preceding text:
https://golang.org/pkg/mime/:
I'm using Chrome 76.0.3809.100 on Linux but it looks roughly the same in Firefox and on an Android phone (if I request desktop site). I don't think this is a browser-specific issue.
/cc @andybons
The text was updated successfully, but these errors were encountered: