Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: insufficient spacing before footer #33638

Closed
cespare opened this issue Aug 13, 2019 · 1 comment
Closed

x/website: insufficient spacing before footer #33638

cespare opened this issue Aug 13, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cespare
Copy link
Contributor

cespare commented Aug 13, 2019

The new website's footer could use extra spacing (and/or a visual separator such as a line or a different background color) to differentiate it from the body.

Right now the spacing depends on the preceding element, so it varies from page to page.

For these two pages, the spacing isn't too bad, but I think it's not enough: the footer looks like part of the page content rather than something different.

https://golang.org/pkg/archive/zip/:

screen_20190813142857

https://blog.golang.org/experiment:

screen_20190813142931

On this page, the spacing is more clearly insufficient and the footer crowds into the preceding text:

https://golang.org/pkg/mime/:

screen_20190813142950

I'm using Chrome 76.0.3809.100 on Linux but it looks roughly the same in Firefox and on an Android phone (if I request desktop site). I don't think this is a browser-specific issue.

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Aug 13, 2019
@katiehockman katiehockman added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Aug 14, 2019
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/190408 mentions this issue: content/static: apply various stylistic fixes

@golang golang locked and limited conversation to collaborators Aug 14, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
+ Adjust the breakpoint in the header nav so that the text
  doesn't overflow at certain widths
+ Change h1-h4 elements to be Work Sans
+ Add a top margin to the footer to give it more space

Fixes golang/go#33638
Fixes golang/go#33652

Change-Id: I60567a6edbb3ddc42333b646b5127d8c328d3712
Reviewed-on: https://go-review.googlesource.com/c/website/+/190408
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants