Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: incorrect deep completions inside of composite literal #33614

Closed
stamblerre opened this issue Aug 13, 2019 · 1 comment
Closed
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@stamblerre
Copy link
Contributor

Repro:

Enable deep completions and code complete inside of the protocol.ServerCapabilities struct literal on line 78 of golang.org/x/tools/internal/lsp/general.go. gopls suggests deep completions that do not make sense in the current context.

Screen Shot 2019-08-13 at 12 38 40 AM

/cc @muirrn

@stamblerre stamblerre added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Aug 13, 2019
@gopherbot gopherbot added this to the Unreleased milestone Aug 13, 2019
@gopherbot
Copy link

Change https://golang.org/cl/190097 mentions this issue: internal/lsp: don't deep complete struct field names

@golang golang locked and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants