Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: simplify validPort after CL 189258 #33600

Closed
bradfitz opened this issue Aug 12, 2019 · 1 comment
Closed

net/http: simplify validPort after CL 189258 #33600

bradfitz opened this issue Aug 12, 2019 · 1 comment
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@bradfitz
Copy link
Contributor

https://go-review.googlesource.com/c/go/+/189258 pushes some URL validation down into net/url that was previously only done in net/http.

We can remove net/http's at this point.

/cc @FiloSottile
@andybons andybons added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Aug 12, 2019
@andybons andybons added this to the Go1.14 milestone Aug 12, 2019
dphan72 added a commit to dphan72/go that referenced this issue Aug 13, 2019
@dphan72
net/http: remove redundant port validation
c19afa3 
The URL port is already checked in net/url, so we can remove the redundant validation in net/http.

Fixes golang#33600
@dphan72 dphan72 mentioned this issue Aug 13, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/190057 mentions this issue: net/http: remove redundant port validation

t4n6a1ka pushed a commit to t4n6a1ka/go that referenced this issue Sep 5, 2019
@dphan72 @t4n6a1ka
net/http: remove redundant port validation
d5916aa 
The URL port is already checked in net/url, so we can remove the redundant validation in net/http.

Fixes golang#33600

Change-Id: I62511a452df6262d4b66180933758d34627ff9df
GitHub-Last-Rev: c19afa3
GitHub-Pull-Request: golang#33611
Reviewed-on: https://go-review.googlesource.com/c/go/+/190057
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

Successfully merging a pull request may close this issue.

net/http: remove redundant port validation dphan72/go
3 participants
@bradfitz @andybons @gopherbot