New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: Client panics if RoundTripper returns neither response nor error #33563
Comments
Hello @Teelevision, thank you for filing this issue and welcome to the Go project! So my apologies if am preaching to the choir; in Go, the idiomatic way of communicating
if we have the case of Right above the lines that you quoted, we've got Lines 115 to 117 in 9c1f14f
which says that RoundTrip returns a Response. Also I believe this doc already says what you'd like it to report Lines 120 to 123 in 9c1f14f
What do you think? |
Ok, thank you, this clarifies it for me. |
What did you do?
Use a http.RoundTripper that returns neither response nor error.
https://play.golang.org/p/EGEjS2P2xQI
What did you expect to see?
Documentation that the RoundTripper MUST return either response or error.
What did you see instead?
go/src/net/http/client.go
Lines 119 to 125 in 1dc0110
The text was updated successfully, but these errors were encountered: