New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: stack depth check too shallow #33555
Comments
Also fails against tip: |
The problem here is that nosplit stack depth check is looking through stacks of non-recursive function calls. There is a limit of 100 calls, on the assumption that there is no longer call sequence. In this example, the call sequence is longer. So the linker complains, although in fact everything is fine. The fix is trivial: increase the limit. This particular example works if we increase the limit to 147. Although this is very late in the 1.13 cycle, I think we would consider backporting a fix for this. So I think it is fair game. |
@gopherbot Please open backport issues. |
Backport issue(s) opened: #33556 (for 1.11), #33557 (for 1.12). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
(This is not a release blocker, though, as it is not a new problem.) |
Change https://golang.org/cl/189697 mentions this issue: |
Change https://golang.org/cl/189717 mentions this issue: |
Change https://golang.org/cl/189737 mentions this issue: |
… stkcheck There is real (albeit generated) code that exceeds the limit. Updates #33555 Fixes #33557 Change-Id: I668e85825d3d2a471970e869abe63f3492213cc1 Reviewed-on: https://go-review.googlesource.com/c/go/+/189697 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> (cherry picked from commit 951143c) Reviewed-on: https://go-review.googlesource.com/c/go/+/189717
… stkcheck There is real (albeit generated) code that exceeds the limit. Updates #33555 Fixes #33556 Change-Id: I668e85825d3d2a471970e869abe63f3492213cc1 Reviewed-on: https://go-review.googlesource.com/c/go/+/189697 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> (cherry picked from commit 951143c) Reviewed-on: https://go-review.googlesource.com/c/go/+/189737
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I am trying to run tests/compile a test executable. The codebase contains large generated files.
Checkout
github.com/gojisvm/gojis
from the branches9-parser
and rungo test -c github.com/gojisvm/gojis/internal/parser
.Note: This issue does not appear when runninggo build ./...
, only when compiling the test executable or running the tests directly withgo test
.After creating
.../internal/parser/main/main.go
with the codeit will now also crash when running
go build ./...
.What did you expect to see?
I expected any kind of compiler output that tells me whether the tests do or do not compile.
What did you see instead?
Additional
I had a conversation on the gophers slack about this issue, maybe the conversation there helps(?)
https://gophers.slack.com/archives/C029RQSEE/p1565298480176500 and downward
The text was updated successfully, but these errors were encountered: