New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: log error frames when logging an error #33499
Comments
According to the blog post https://blog.golang.org/experiment the design draft for printing frames is abandoned and they are on a look out for a better solution. I am not sure if the current implementation will stay. Do you have any more insights on this @stamblerre ? My idea was to print the errors with |
Ah, I missed Russ's talk at GopherCon. I think I'm fine with using the features supported by I think we could make these changes quite simple and easy to revert because @ianthehat's telemetry work introduced a new way of logging errors. Supporting this behavior might be as simple as adding the |
Just printing errors as Thanks for the hint :) I'll try it out locally. Any hint on how to reliably cause an error? |
Something like messing with the name of the package, adding an import that doesn't exist, completing something that's not declared - these would all likely cause errors to be logged. |
Change https://golang.org/cl/189344 mentions this issue: |
Now that we are using x/errors in
gopls
, we can also log error frames when logging errors.@jan-xyz is interested in adding this behavior.
The text was updated successfully, but these errors were encountered: