New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: another typo in Response.Body field docs #33453
Comments
Good catch! Would you like to submit a change for this (https://golang.org/doc/contribute.html)? Also (let's see if this works), @gopherbot, add NeedsFix, "help wanted", Documentation. |
Sure, would love to! Thanks. |
Change https://golang.org/cl/188541 mentions this issue: |
Thank you for filing this issue @sanjib and welcome to the Go project! Thank you for the triage @smasher164 too and for chiming in @shivi28! I had just posted feedback on your CL @shivi28 and on coming here noticed that @sanjib had already committed to it. @sanjib sorry about that, but could you please perhaps let @shivi28 take this one as they already have the CL out, and in the future @shivi28 please take a look at who has responded in case they are already working on the fix :) |
@odeke-em hey no problem, thanks! :-) |
@shivi28 don't worry, this was a classic go race condition :-) |
@sanjib - Don't worry, you are now done with your setup, and this issue tracker will keep having new issues. And I'm pretty sure if you go through old issues searching for "Documentation"/ "help wanted"/ "suggested" labels, you can find something that you feel comfortable contributing to. See this for more info. |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Read the documentation in file: ~/src/net/http/response.go
Found grammatical issue in field Body of struct Response, around line 68
What did you expect to see?
// As of Go 1.12, the Body will also implement io.Writer
What did you see instead?
// As of Go 1.12, the Body will be also implement io.Writer
The text was updated successfully, but these errors were encountered: