Comment 1:

TCP has it, so I'm guessing it could be added to UnixConn after Go 1.
http://code.google.com/p/go/source/detail?r=f68009c4a907

Comment 2:

I've been playing with gob over unix sockets, and I don't always get an error in the
decoder if the remote end closes the socket after an encode error. Maybe it also has to
do CloseWrite (shutdown) before it closes?

Comment 3:

Yep, just tested this. Should we try to sneak in another net CL? :-)

Comment 4:

Here's an example app which behaves better if you have CloseWrite on the unix socket. I
just don't understand how it's supposed to work in the case where the remote end crashes
instead of shutting down cleanly.

Attachments:

1. unix.go (2006 bytes)

Comment 5:

I think there is a bigger problem. Here is a better test:
UnixPair sameProcClose closeWrite=false   hang
UnixPair sameProcClose closeWrite=true    ok
UnixPair childProcClose flag=panic        hang
UnixPair childProcClose flag=close        hang
UnixPair childProcClose flag=closeWrite   ok
UnixConnectedPair sameProcClose cw=false  ok
UnixConnectedPair sameProcClose cw=true   ok
UnixConnectedPair childProcClose panic    hang
UnixConnectedPair childProcClose close    hang
UnixConnectedPair childProcClose cw       ok
As I understand it, all of these should work.

Attachments:

1. unix.go (3099 bytes)

Comment 6:

Fixed up my unixPair function to close the output of os.NewFile after calling
net.FileConn, since it does a dup. A few more work now. Still investigating.

Attachments:

1. unix.go (3432 bytes)

Comment 7:

Okay, I fixed all the tests. So closing at least works to kill the connection, if you
make 100% sure you don't have extra file descriptors for it lying around in your process.

Attachments:

1. unix.go (4403 bytes)

Comment 8:

Labels changed: added priority-later, packagechange, removed priority-triage.

Status changed to Accepted.

Comment 9:

Ping.
Would such a change be accepted for Go 1.1 or 1.x? Are there things to watch in
particular when it comes to Unix domain sockets specification?

Comment 10:

Feel free to submit a patch.

Comment 11:

This issue was closed by revision 0ce9045.

Status changed to Fixed.