Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: missing SIGSTKFLT for mips64le #33381

Closed
ydcool opened this issue Jul 31, 2019 · 2 comments
Closed

x/sys/unix: missing SIGSTKFLT for mips64le #33381

ydcool opened this issue Jul 31, 2019 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@ydcool
Copy link

ydcool commented Jul 31, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.5 linux/mips64le

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="mips64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="mips64le"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/opt/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go-go1.12.5"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-go1.12.5/pkg/tool/linux_mips64le"
GCCGO="gccgo"
GOMIPS64="hardfloat"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build457678816=/tmp/go-build -gno-record-gcc-switches"

What did you do?

git clone -b v18.09.8-ce https://github.com/docker/docker-ce "$GOPATH/src/github.com/docker/"
cd $GOPATH/src/github.com/docker
ln -s $GOPATH/src/github.com/docker/docker-ce/components/engine docker
cd $GOPATH/src/github.com/docker/docker
sh -x ./hack/make.sh dynbinary

What did you expect to see?

build docker without error related to golang.org/x/sys

What did you see instead?

# github.com/docker/docker/pkg/signal
pkg/signal/signal_linux.go:35:14: undefined: unix.SIGSTKFLT
@gopherbot gopherbot added this to the Unreleased milestone Jul 31, 2019
@ydcool
Copy link
Author

ydcool commented Jul 31, 2019 •
edited

I wonder if I could submit a PR for golang.org/x/sys/unix/zerros_linux_mips64le.go, just adding the code like this:

SIGSTKFLT = syscall.Signal(0x16)

And this works for me.

@ianlancetaylor
Copy link
Contributor

As far as I can tell, the x/sys/unix package is correct. MIPS64le GNU/Linux does not have a SIGSTKFLT signal. Signal number 0x16 is SIGIO aka SIGPOLL. You would see the same error compiling an equivalent C program on MIPS64le GNU/Linux. Note that in the x86 header file SIGSTKFLT is marked as obsolete.

This needs to be fixed in Docker itself.

@ydcool ydcool mentioned this issue Dec 31, 2019
Closed
@golang golang locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @ydcool @gopherbot