Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/stringer: ARM cross-build fails #33354

Closed
andig opened this issue Jul 29, 2019 · 8 comments
Closed

x/tools/cmd/stringer: ARM cross-build fails #33354

andig opened this issue Jul 29, 2019 · 8 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@andig
Copy link
Contributor

andig commented Jul 29, 2019 •
edited
Loading

What version of Go are you using (go version)?

$ go version
go version go1.12.7 darwin/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/andig/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/andig/htdocs/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/opt/go/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/opt/go/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/andig/htdocs/mbmd/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-build085038192=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Run cross-build of

GOARCH=arm GOARM=6 make build

What did you expect to see?

Clean build

What did you see instead?

OSX:

Generating embedded assets
go generate ./...
# golang.org/x/tools/cmd/stringer
runtime.save_g: relocation target runtime.read_tls_fallback not defined
runtime.load_g: relocation target runtime.read_tls_fallback not defined
runtime._initcgo: relocation target runtime.read_tls_fallback not defined
meters/measurements.go:23: running "go": exit status 2
# github.com/mjibson/esc
runtime.save_g: relocation target runtime.read_tls_fallback not defined
runtime.load_g: relocation target runtime.read_tls_fallback not defined
runtime._initcgo: relocation target runtime.read_tls_fallback not defined
server/http.go:21: running "go": exit status 2
make: *** [assets] Error 1

Travis (go version go1.12 linux/amd64)

go generate ./...
fork/exec /tmp/go-build169921720/b001/exe/stringer: exec format error
meters/measurements.go:23: running "go": exit status 1
fork/exec /tmp/go-build179584689/b001/exe/doc: exec format error
server/http.go:21: running "go": exit status 1
make: *** [Makefile:27: assets] Error 1
The command '/bin/sh -c GOARCH=arm GOARM=6 make build' returned a non-zero code: 2

My feeling (nothing more) is that is a recent problem as I was able to cross-build using stringer before on other projects. For sake of reference there's an entire build log in https://travis-ci.org/volkszaehler/mbmd.
@gopherbot gopherbot added this to the Unreleased milestone Jul 29, 2019
@andig
Copy link
Contributor Author

andig commented Jul 29, 2019

Update: trying without GOARM I get:

❯ GOARCH=arm make build
Generating embedded assets
go generate ./...
# golang.org/x/tools/cmd/stringer
/usr/local/opt/go/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: ignoring file /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-link-125095315/go.o, file was built for armv7 which is not the architecture being linked (x86_64): /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-link-125095315/go.o
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@andig andig changed the title x/tools/stringer cross-build fails x/tools/stringer ARM cross-build fails Jul 29, 2019
@agnivade
Copy link
Contributor

To be clear, you are running make build on https://github.com/volkszaehler/mbmd ?

cc @ianlancetaylor @randall77

@andig
Copy link
Contributor Author

andig commented Jul 30, 2019 •
edited
Loading

Exactly. Out of that is is specifically

go generate ./...

that fails. I could try bisecting older go versions?

@dmitshur dmitshur changed the title x/tools/stringer ARM cross-build fails x/tools/cmd/stringer: ARM cross-build fails Jul 30, 2019
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 30, 2019
@dmitshur
Copy link
Contributor

There is some sort of problem, but it's hard to tell where exactly it is.

First, what kind of architecture are you using? In the issue title you say ARM, but in the "go version" output I see "darwin/amd64". Are you on a Mac?

To confirm whether cmd/stringer is involved or not, can you try building it directly?

go build golang.org/x/tools/cmd/stringer

@dmitshur dmitshur added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 30, 2019
@andig
Copy link
Contributor Author

andig commented Jul 30, 2019 •
edited
Loading

First, what kind of architecture are you using? In the issue title you say ARM, but in the "go version" output I see "darwin/amd64". Are you on a Mac?

I ran into the problem on travis-ci and later saw something similar on OSX, hence the double report. Here are some things I've tried on OSX:

❯ go version
go version go1.12.7 darwin/amd64

❯ go generate ./...

❯ GOARCH=arm go generate ./...
# golang.org/x/tools/cmd/stringer
/usr/local/opt/go/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: ignoring file /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-link-714679626/go.o, file was built for armv7 which is not the architecture being linked (x86_64): /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-link-714679626/go.o
Undefined symbols for architecture x86_64:
"_main", referenced from:
    implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

meters/measurements.go:23: running "go": exit status 2
# github.com/mjibson/esc
/usr/local/opt/go/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: warning: ignoring file /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-link-536613157/go.o, file was built for armv7 which is not the architecture being linked (x86_64): /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-link-536613157/go.o
Undefined symbols for architecture x86_64:
"_main", referenced from:
    implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

server/http.go:21: running "go": exit status 2

❯ GOOS=linux GOARCH=amd64 go build golang.org/x/tools/cmd/stringer

❯ GOOS=linux GOARCH=arm go build golang.org/x/tools/cmd/stringer

❯ GOOS=linux GOARCH=ARM go build golang.org/x/tools/cmd/stringer
cmd/go: unsupported GOOS/GOARCH pair linux/ARM

but

❯ GOOS=linux GOARCH=arm make build
Generating embedded assets
go generate ./...
fork/exec /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-build317921363/b001/exe/stringer: exec format error
meters/measurements.go:23: running "go": exit status 1
fork/exec /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-build548060984/b001/exe/doc: exec format error
server/http.go:21: running "go": exit status 1
make: *** [assets] Error 1

and

❯ GOOS=linux GOARCH=arm go generate ./...
fork/exec /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-build027256891/b001/exe/stringer: exec format error
meters/measurements.go:23: running "go": exit status 1
fork/exec /var/folders/w5/_c0nb6n90fn96tzw04dtc6240000gn/T/go-build880784254/b001/exe/doc: exec format error
server/http.go:21: running "go": exit status 1

So cross-building stringer is fine but using it during go generate isn't?

@ianlancetaylor
Copy link
Member

The go:generate comments in https://github.com/volkszaehler/mbmd are

//go:generate go run golang.org/x/tools/cmd/stringer -type=Measurement
//go:generate go run github.com/mjibson/esc -private -o assets.go -pkg server -prefix ../assets ../assets

You are explicitly invoking go run. Setting GOARCH in the environment is telling go run to build a binary that runs on ARM. The stringer binary requires external linking for some reason (I haven't looked) but you are using a native compiler rather than an ARM cross-compiler. That is why you are getting the error you are getting. Even if the stringer binary didn't require external linking, the operation would still fail as your system cannot run a binary built for ARM.

The usual approach, the one used in, for example, the Go standard library, is to run go install golang.org/x/tools/cmd/stringer and use go:generate comments that look like

//go:generate stringer -type=Measurement

If you choose to write your go:generate comments to use go run, I'm not sure if there is a reasonable way to fix this.

@andig
Copy link
Contributor Author

andig commented Jul 30, 2019 •
edited
Loading

I'm sorry, feeling ashamed and stupid. Still- while closing this as invalid- I'd still be interested in how to properly install build dependencies. I do have a tools.go:

// +build tools

package mbmd

import (
	_ "github.com/mjibson/esc"
	_ "golang.org/x/tools/cmd/stringer"
)

but that doesn't seem to suffice to make the executables available for build:

meters/measurements.go:23: running "stringer": exec: "stringer": executable file not found in $PATH
server/http.go:21: running "esc": exec: "esc": executable file not found in $PATH
Makefile:26: recipe for target 'assets' failed

Would be great to round this off for other potential users.

EDIT

OK, guess I've found that mistake, too: package was mbmd while it should have been main. After changing to main it seems to work. A but confusing since go didn't raise an error about conflicting package names in this case.

@andig andig closed this as completed Jul 30, 2019
@ianlancetaylor
Copy link
Member

No reason to feel ashamed or stupid, it was a perfectly reasonable question.

@andig andig mentioned this issue Aug 19, 2019
Closed
@golang golang locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@andig @agnivade @dmitshur @ianlancetaylor @gopherbot