-
Notifications
You must be signed in to change notification settings - Fork 18k
os: Chtimes fails on FAT32 #33335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@bep I'm sorry if I've caused you additional, unnecessary work, but I hope you can appreciate how "chtimes fails on FAT32" as a bug report is vastly different from asking "why is there a colon in the error message of this software I am using". I did not close the original issue because it was referred from Hugo, I closed it because it provided no useful information, had a straightforward answer to the asked question, and made no indication that it was originally filed elsewhere. Rather, it looked like one of many instances of "I'm using a program written in Go and it displays an error I don't understand". I'm sure you can see that such a description doesn't imply a bug in Go itself, and rather looks like difficulty in using some software written in Go. And it is natural to refer users to the issue tracker of the software they are having difficulty with. |
And, of course, to be remotely able to debug this issue, the user needs to fill in the issue template, and provide a minimal example that reproduces the issue. Which implies they need to be able to write and run Go code. They also need to dig into Hugo to figure out how exactly it is calling chtimes. |
@bep I have no idea what your problem is, because you did not explain. So I just tried few things. In particular we have TestChtimes test in os package. And it tests os.Chtimes. I inserted USB flash disk into my computer (as D: drive), and then did this
So the TestChtimes indeed fails when FAT is used. But os.Chtimes uses Windows API SetFileTime to implement whatever it does. And according to https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-setfiletime
And, indeed, if I change TestChtimes
it passes. So it is hit and miss when you use FAT. Let me know, if you want us to do anything else for this issue. Thank you. Alex |
sound good like a solution :-) |
@gj52 - From the comment above, it seems like it is WAI. So there is no solution here, because there is no bug. The
You are certainly welcome to improve the error message, but this issue is specifically about |
@agnivade Hi, I would change the parameter sequence, first the error and than the wrong parameters |
We're not going to change the format of this error. It has been stable for years, and is consistent with other errors. Also, please, let's stay on topic. This issue is about Chtimes failing, not the styling of the error. |
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
Wanted to comment and mention that this issue also appears to affect exFAT. The following is encountered during a
|
I can also replicate this error for exfat. |
I encountered the same chtimes error in not finding path to /public when the source was on exFat. Switched source to a NTFS partition and the problem was gone. I was using Rstudio and blogdown. |
This is a refurbished version of #33334
I some times refer Hugo users to this issue tracker when I'm 99.9% certain that this is the right place for such an issue.
I don't have the bandwidth to track down all the Go issues I find on that project. I do when it hurts me enough, and I do maintain a large test suite that I test on 3x3 platforms/Go versions, which sometimes finds bugs/regressions in Go itself. Which is a win/win in this big dugnad project we call open source.
Which is why I would appreciate if you don't just brush it off as a non-issue if you see some unrelated package in the bug report.
gohugoio/hugo#6127
/cc @gj52
The text was updated successfully, but these errors were encountered: