Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: log debug server port in the gopls log file, not stderr #33324

Closed
stamblerre opened this issue Jul 27, 2019 · 6 comments
Closed

x/tools/internal/lsp: log debug server port in the gopls log file, not stderr #33324

stamblerre opened this issue Jul 27, 2019 · 6 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

Because debug.Serve gets called before we get an initialize request, we log to stderr instead of the log.
@gopherbot gopherbot added this to the Unreleased milestone Jul 27, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jul 27, 2019
@stamblerre stamblerre added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed gopls Issues related to the Go language server, gopls. labels Jul 27, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jul 27, 2019
@ianthehat
Copy link

Yeah, this came up when talking to Billie.
The idea is that we should enable debug pages by default, but to do that we need to default to :0 so they get unique ports, and that means we need an easy way of finding out what port it picked, and ideally the plugin would be able to find out so that it can just open the debug page.
It is probably worth noting that we could pick other ways of reporting the port number chosen for this purpose.

@stamblerre stamblerre modified the milestones: Unreleased, gopls unplanned Dec 4, 2019
@stamblerre
Copy link
Contributor Author

stamblerre commented Jan 29, 2020 •
edited

@bhcleek: If I recall correctly, you sent out a CL for this, right? Is this still an issue for you?

@stamblerre stamblerre modified the milestones: gopls unplanned, gopls/v1.0.0 Jan 29, 2020
@bhcleek
Copy link
Contributor

bhcleek commented Jan 29, 2020 •
edited

My CL, https://go-review.googlesource.com/c/tools/+/211798, was merged. I'll verify it's still working on the pending release, golang.org/x/tools/gopls@v0.3.0-pre2, tonight and will report back.

@stamblerre
Copy link
Contributor Author

Perfect, thank you!

@stamblerre stamblerre added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 29, 2020
@bhcleek
Copy link
Contributor

bhcleek commented Jan 30, 2020

v0.3.0-pre2 outputs the port as expected.

@stamblerre
Copy link
Contributor Author

Thanks for confirming! Closing this issue then.

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
4 participants
@ianthehat @bhcleek @stamblerre @gopherbot