Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/openpgp: Could EncryptedKey.Decrypt be extended to help support keys kept in a hardware module #33301

Closed
ragansa opened this issue Jul 26, 2019 · 2 comments
Closed

x/crypto/openpgp: Could EncryptedKey.Decrypt be extended to help support keys kept in a hardware module #33301

ragansa opened this issue Jul 26, 2019 · 2 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@ragansa
Copy link

ragansa commented Jul 26, 2019

For all the same points made in: #15841
And similar to the change made in: https://go-review.googlesource.com/c/crypto/+/23802/

https://github.com/golang/crypto/blob/master/openpgp/packet/encrypted_key.go#L80-L86
Uses concrete implementations, could we instead take the decrypter interface instead?

Specifically, we're using a hardware backed RSA key and want to use it for PGP decryption.

Thanks in advance!
@gopherbot gopherbot added this to the Unreleased milestone Jul 26, 2019
@ragansa
Copy link
Author

ragansa commented Jul 26, 2019

cc @ivmaykov

@FiloSottile FiloSottile added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 30, 2019
@ragansa ragansa mentioned this issue Aug 8, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/189497 mentions this issue: allow using custom decryptor in openpgp RSA decrypt path

chintanparikh pushed a commit to opendoor-labs/openpgp that referenced this issue Dec 11, 2019
@FiloSottile
openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
11d759c 
Fixes golang/go#33301

Change-Id: I74a389367d34d4718d70349794027ed9f1eca370
GitHub-Last-Rev: 6d95cdf63248a54b134027ed49641c204187f188
GitHub-Pull-Request: golang/crypto#94
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 1, 2020
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@FiloSottile
openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
b4dec6f 
Fixes golang/go#33301

Change-Id: I74a389367d34d4718d70349794027ed9f1eca370
GitHub-Last-Rev: 6d95cdf63248a54b134027ed49641c204187f188
GitHub-Pull-Request: golang/crypto#94
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@c-expert-zigbee
openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
5f97806 
Fixes golang/go#33301

Change-Id: I74a389367d34d4718d70349794027ed9f1eca370
GitHub-Last-Rev: 6d95cdf63248a54b134027ed49641c204187f188
GitHub-Pull-Request: golang/crypto#94
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@c-expert-zigbee
openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
e14744a 
Fixes golang/go#33301

Change-Id: I74a389367d34d4718d70349794027ed9f1eca370
GitHub-Last-Rev: 6d95cdf63248a54b134027ed49641c204187f188
GitHub-Pull-Request: golang/crypto#94
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@FiloSottile
openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
b8ef55f 
Fixes golang/go#33301

Change-Id: I74a389367d34d4718d70349794027ed9f1eca370
GitHub-Last-Rev: 6d95cdf63248a54b134027ed49641c204187f188
GitHub-Pull-Request: golang/crypto#94
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@FiloSottile
openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
007c051 
Fixes golang/go#33301

Change-Id: I74a389367d34d4718d70349794027ed9f1eca370
GitHub-Last-Rev: 6d95cdf
GitHub-Pull-Request: golang#94
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/189497
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

openpgp/packet: support crypto.Decrypter in EncryptedKey.Decrypt
3 participants
@FiloSottile @gopherbot @ragansa