Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/imports: tests broken with go/packages on tip #33175

Closed
stamblerre opened this issue Jul 18, 2019 · 4 comments
Closed

x/tools/internal/imports: tests broken with go/packages on tip #33175

stamblerre opened this issue Jul 18, 2019 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

/cc @heschik
@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 18, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2019
@gopherbot
Copy link

Change https://golang.org/cl/186838 mentions this issue: internal/imports: disable go/packages-incompatible tests

gopherbot pushed a commit to golang/tools that referenced this issue Jul 18, 2019
@stamblerre
internal/imports: disable go/packages-incompatible tests
72478f3 
A recent change to the go command broke these tests. Mark them as
go/packages incompatible for now, until we have time to fix them.

Updates golang/go#33175

Change-Id: Ib4c594bd032107fb1245bfe18fc80392fbab0730
Reviewed-on: https://go-review.googlesource.com/c/tools/+/186838
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
@heschi
Copy link
Contributor

heschi commented Jul 30, 2019

@jayconrod said he's aware of other breakages to go/packages caused by the same CL (https://golang.org/cl/154100) and will look at this.

@jayconrod
Copy link
Contributor

Possibly related to #33157

@gopherbot
Copy link

Change https://golang.org/cl/188379 mentions this issue: x/tools/internal/imports: don't load package names for empty list

@golang golang locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@jayconrod @stamblerre @gopherbot @heschi