Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: use Google fonts for Roboto #33164

Closed
freeformz opened this issue Jul 18, 2019 · 2 comments
Closed

x/website: use Google fonts for Roboto #33164

freeformz opened this issue Jul 18, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@freeformz
Copy link

What did you do?

Visit http://golang.org/pkg/log

What did you expect to see?

A website with css that selects a font that is likely to be on my system or is sourced from the internet.

What did you see instead?

The website uses the Roboto font. This font isn't installed on Macs, but could be sourced from the internet with a <link/> in the <head/> of the website like so:

<html lang="en">
  <head>
    ...
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto">
   ...
  </head>
...

I realized there are fallback fonts (Arial & sans-serif), but they don't look as good. Please link the google font. Thanks!
@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 18, 2019
@FiloSottile FiloSottile changed the title website: roboto font problems x/website: roboto font problems Jul 18, 2019
@FiloSottile
Copy link
Contributor

/cc @andybons

@gopherbot gopherbot added this to the Unreleased milestone Jul 18, 2019
@andybons andybons changed the title x/website: roboto font problems x/website: use Google fonts for Roboto Jul 19, 2019
@gopherbot
Copy link

Change https://golang.org/cl/188983 mentions this issue: content/static: update footer styling

@golang golang locked and limited conversation to collaborators Aug 6, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: update footer styling
5f8b847 
+ Updates styling to accomodate smaller viewports
+ Adds “Supported by” as a preface to the Google logo
+ Pulls in Roboto and Product Sans from Google Fonts

Fixes golang/go#33164
Fixes golang/go#33100

Change-Id: I43a8bfad05e67301a055ab91751f3868ef899210
Reviewed-on: https://go-review.googlesource.com/c/website/+/188983
Reviewed-by: Katie Hockman <katie@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@freeformz @FiloSottile @gopherbot