Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: html end tag missing on golang.org/dl #33126

Closed
tsaarni opened this issue Jul 15, 2019 · 1 comment
Closed

x/website: html end tag missing on golang.org/dl #33126

tsaarni opened this issue Jul 15, 2019 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@tsaarni
Copy link
Contributor

tsaarni commented Jul 15, 2019

What did you do?

Download https://golang.org/dl/ and parse it with gopkg.in/xmlpath.v1.ParseHTML.

What did you expect to see?

Parsing should succeed.

What did you see instead?

Error XML syntax error on line 11670: unexpected EOF

The reason seems to be that the web page does not have </html> end tag which gopkg.in/xmlpath.v1.ParseHTML is expecting.

This breaks godeb tool, see issue niemeyer/godeb#44. Workaround is to update parser to gopkg.in/xmlpath.v2.ParseHTML which is more forgiving.
@gopherbot gopherbot added this to the Unreleased milestone Jul 15, 2019
@andybons andybons mentioned this issue Jul 15, 2019
Closed
@andybons
Copy link
Member

Thanks for the issue.

HTML5 does not require all tags be closed. The <html> tag falls into that category.

There is a JSON API that should be used instead of parsing the HTML (which is brittle and prone to change). https://golang.org/dl/?mode=json[&include=all]

Closing since no change is needed on our side (please use the JSON API or a parser that is more compatible with HTML5).

@tsaarni tsaarni mentioned this issue Jul 16, 2019
Merged
@golang golang locked and limited conversation to collaborators Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@tsaarni @andybons @gopherbot