Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp: nodisk test broken at tip #33125

Closed
ianthehat opened this issue Jul 15, 2019 · 2 comments
Closed

x/tools/internal/lsp: nodisk test broken at tip #33125

ianthehat opened this issue Jul 15, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Milestone
Unreleased

Comments

@ianthehat
Copy link

Something change in go (probably https://go-review.googlesource.com/c/go/+/185417) that causes the nodisk.golden.go file to no longer be processed by the expectation system in module mode only. This results in an incorrect count for completion tests.
I have confirmed that the flow switched from a reclaimed package to a new package in this case, but I do not know why that would cause it t fail, as there are tests for that flow that seem to work.
@ianthehat ianthehat added the gopls Issues related to the Go language server, gopls. label Jul 15, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jul 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/186259 mentions this issue: internal/lsp: add temporary file to fix bug with tip go

gopherbot pushed a commit to golang/tools that referenced this issue Jul 15, 2019
@ianthehat
internal/lsp: add temporary file to fix bug with tip go
9b2cb0e 
There is a problem with this test failing in module mode only with the
tip of the go tree. Adding this file changes it from a pure overlay package
to one that has an extra file, which fixes it for now.

updates golang/go#33125

Change-Id: I87dae0b44691246a1f79df454afb190f944cc886
Reviewed-on: https://go-review.googlesource.com/c/tools/+/186259
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@stamblerre
Copy link
Contributor

This is really a symptom of #33157, so closing this issue in favor of that one.

@golang golang locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianthehat @stamblerre @gopherbot