You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Something change in go (probably https://go-review.googlesource.com/c/go/+/185417) that causes the nodisk.golden.go file to no longer be processed by the expectation system in module mode only. This results in an incorrect count for completion tests.
I have confirmed that the flow switched from a reclaimed package to a new package in this case, but I do not know why that would cause it t fail, as there are tests for that flow that seem to work.
The text was updated successfully, but these errors were encountered:
There is a problem with this test failing in module mode only with the
tip of the go tree. Adding this file changes it from a pure overlay package
to one that has an extra file, which fixes it for now.
updates golang/go#33125
Change-Id: I87dae0b44691246a1f79df454afb190f944cc886
Reviewed-on: https://go-review.googlesource.com/c/tools/+/186259
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Something change in go (probably https://go-review.googlesource.com/c/go/+/185417) that causes the nodisk.golden.go file to no longer be processed by the expectation system in module mode only. This results in an incorrect count for completion tests.
I have confirmed that the flow switched from a reclaimed package to a new package in this case, but I do not know why that would cause it t fail, as there are tests for that flow that seem to work.
The text was updated successfully, but these errors were encountered: