Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: footer text is cut off on smaller viewports #33100

Closed
komuw opened this issue Jul 13, 2019 · 2 comments
Closed

x/website: footer text is cut off on smaller viewports #33100

komuw opened this issue Jul 13, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@komuw
Copy link
Contributor

komuw commented Jul 13, 2019 •
edited

What did you do?

What did you expect to see?

  • everything well laid out

What did you see instead?

  • the letter 'R' in 'Report a website issue' is missing
  • there's no space before the google logo

IMG-0304

  • my phone is iphone SE
  • browser; chrome
@gopherbot gopherbot added this to the Unreleased milestone Jul 13, 2019
@agnivade agnivade added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 14, 2019
@andybons andybons changed the title x/website: bad layout on mobile x/website: footer text is cut off on smaller viewports Jul 15, 2019
@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 15, 2019
@andybons
Copy link
Member

Added NeedsFix but it's unclear what fixed means (perhaps changing the text to be "Report issue" is enough).

@gopherbot
Copy link

Change https://golang.org/cl/188983 mentions this issue: content/static: update footer styling

@golang golang locked and limited conversation to collaborators Aug 6, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: update footer styling
5f8b847 
+ Updates styling to accomodate smaller viewports
+ Adds “Supported by” as a preface to the Google logo
+ Pulls in Roboto and Product Sans from Google Fonts

Fixes golang/go#33164
Fixes golang/go#33100

Change-Id: I43a8bfad05e67301a055ab91751f3868ef899210
Reviewed-on: https://go-review.googlesource.com/c/website/+/188983
Reviewed-by: Katie Hockman <katie@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @agnivade @komuw @gopherbot