Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/memoize: detect cycles in keys #33044

Closed
stamblerre opened this issue Jul 10, 2019 · 1 comment
Closed

x/tools/internal/memoize: detect cycles in keys #33044

stamblerre opened this issue Jul 10, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

Right now, there is no cycle detection, so if you request the a key while you are in the process of evaluating the same key, it will hang.

/cc @ianthehat
@stamblerre stamblerre added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. labels Jul 10, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2019
@ianthehat ianthehat self-assigned this Jul 10, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@stamblerre stamblerre removed the gopls Issues related to the Go language server, gopls. label Dec 4, 2019
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 14, 2020
@stamblerre stamblerre added the gopls Issues related to the Go language server, gopls. label Apr 14, 2020
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 24, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@stamblerre
Copy link
Contributor Author

Obsolete.

@stamblerre stamblerre removed this from the gopls/unplanned milestone Nov 13, 2020
@golang golang locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianthehat @stamblerre @gopherbot