New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/website: inconsistent headers #33043
Comments
Golang.org congratulations for the new design. I have my question where is the code of the page? AND Thank you for the report, you are looking if someone had uploaded it |
@AndrusGerman The code is at https://github.com/golang/website. If you have other questions, the golang-nuts mailing list is a better place to ask them. |
@jadekler On the home page https://golang.org there is an PS WOW. Now https://golang.org/dl has also missing PPS |
/cc @andybons |
Previously, the "Play" link showed a popup of the playground much like what is on the golang.org landing page, which is why (I'm guessing) it was hidden on the homepage. This should be fixed to show the Play link on all pages since it now links to play.golang.org. |
@andybons From what i can tell this seems to be fixed already. |
@ivenk “Play” is not present in the navigation header on https://golang.org/, so this is not yet fixed. |
@andybons oh ... yeah you are correct. My bad. |
Change https://golang.org/cl/187897 mentions this issue: |
…landing page The "Play" link is visible when the page title is set, but it's not set on the landing page. By this change, the "Play" link is visible no matter whether the page title is set. Fixes golang/go#33043 Change-Id: I6a35e3d5c3d54ba5bd3d23967196cb7edaeefa22 Reviewed-on: https://go-review.googlesource.com/c/website/+/187897 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
At https://golang.org the headers are:
At https://golang.org/dl/ the headers are:
Note that Play is in the latter but not the former.
The text was updated successfully, but these errors were encountered: