Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: inconsistent headers #33043

Closed
jeanbza opened this issue Jul 10, 2019 · 9 comments
Closed

x/website: inconsistent headers #33043

jeanbza opened this issue Jul 10, 2019 · 9 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@jeanbza
Copy link
Member

jeanbza commented Jul 10, 2019

At https://golang.org the headers are:

Screen Shot 2019-07-10 at 3 51 24 PM

At https://golang.org/dl/ the headers are:

Screen Shot 2019-07-10 at 3 51 42 PM

Note that Play is in the latter but not the former.
@dmitshur dmitshur changed the title golang.org: inconsistent headers x/website: inconsistent headers Jul 10, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2019
@AndrusGerman
Copy link

Golang.org congratulations for the new design. I have my question where is the code of the page? AND Thank you for the report, you are looking if someone had uploaded it

@ALTree
Copy link
Member

ALTree commented Jul 11, 2019

@AndrusGerman The code is at https://github.com/golang/website.

If you have other questions, the golang-nuts mailing list is a better place to ask them.

@av86743
Copy link

av86743 commented Jul 11, 2019 •
edited

@jadekler

On the home page https://golang.org there is an Open in playground link, which makes menu item Play kind of redundant. It would be of course nicer if that link would open in a separate tab/window for larger screens, but that's a different point.

PS WOW. Now https://golang.org/dl has also missing Blog from the menu.

PPS Blog and Play are back on https://golang.org/dl menu. So much for controlled content.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 15, 2019
@dmitshur
Copy link
Contributor

/cc @andybons

@andybons
Copy link
Member

Previously, the "Play" link showed a popup of the playground much like what is on the golang.org landing page, which is why (I'm guessing) it was hidden on the homepage. This should be fixed to show the Play link on all pages since it now links to play.golang.org.

@andybons andybons added help wanted NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 15, 2019
@ivenk
Copy link

ivenk commented Jul 24, 2019

@andybons From what i can tell this seems to be fixed already.

@andybons
Copy link
Member

@ivenk “Play” is not present in the navigation header on https://golang.org/, so this is not yet fixed.

@ivenk
Copy link

ivenk commented Jul 25, 2019

@andybons oh ... yeah you are correct. My bad.

@gopherbot
Copy link

Change https://golang.org/cl/187897 mentions this issue: content/static: show the "Play" link in the navigation header on the landing page

@golang golang locked and limited conversation to collaborators Jul 28, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: show the "Play" link in the navigation header on the …
af8e560 
…landing page

The "Play" link is visible when the page title is set, but it's not set on the landing page.
By this change, the "Play" link is visible no matter whether the page title is set.

Fixes golang/go#33043

Change-Id: I6a35e3d5c3d54ba5bd3d23967196cb7edaeefa22
Reviewed-on: https://go-review.googlesource.com/c/website/+/187897
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
8 participants
@andybons @av86743 @dmitshur @jeanbza @ALTree @gopherbot @AndrusGerman @ivenk