Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: header navigation links have smaller click target #33039

Closed
andybons opened this issue Jul 10, 2019 · 1 comment
Closed

x/website: header navigation links have smaller click target #33039

andybons opened this issue Jul 10, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@andybons
Copy link
Member

On the original golang.org the click target for the nav links is much larger. This has regressed in the new design and should be fixed.

/cc @dominikh
@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 10, 2019
@andybons andybons added this to the Unreleased milestone Jul 10, 2019
@gopherbot
Copy link

Change https://golang.org/cl/185982 mentions this issue: content/static: increase click target of nav elements

@golang golang locked and limited conversation to collaborators Jul 11, 2020
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static: increase click target of nav elements
39dc215 
This change increases the click targets of the nav links by adding
padding to the anchor links.

There are no visual changes.

Fixes golang/go#33039

Change-Id: Id308f042f979910ec7d9396a0a8829ca2dfcd878
Reviewed-on: https://go-review.googlesource.com/c/website/+/185982
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@andybons @gopherbot