New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: prefer registering formatting provider dynamically #32989
Comments
Thanks for filing this @stamblerre, happy to contribute a patch if I can get more information on where this change should live |
Absolutely - that would be great! It would have to be in https://github.com/golang/tools/blob/master/internal/lsp/general.go - in the initialize and initialized functions, which correspond to the https://microsoft.github.io/language-server-protocol/specification#initialize and https://microsoft.github.io/language-server-protocol/specification#initialized requests. Basically, you'd have to check if the client supports dynamic configuration in initialize, and if so, do the dynamic configuration in initialized. Feel free to ask follow up questions if you need more clarification here. |
It seems there is already a check in |
Yes, that's exactly the place to do it. It would look the same way, only you would be registering the |
Fixes golang/go#32989 Signed-off-by: Vince Prignano <vince@vincepri.com>
Fixes golang/go#32989 Signed-off-by: Vince Prignano <vince@vincepri.com>
Change https://golang.org/cl/185244 mentions this issue: |
Closing as discussed on the above CL. |
Forked from microsoft/vscode-go#2446.
The text was updated successfully, but these errors were encountered: