Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: wrong errors from ReadRequest #3298

Closed
gopherbot opened this issue Mar 12, 2012 · 2 comments
Closed

net/http: wrong errors from ReadRequest #3298

gopherbot opened this issue Mar 12, 2012 · 2 comments
Milestone

Comments

@gopherbot
Copy link

by peterthrun@ymail.com:

What steps will reproduce the problem?
1. http://play.golang.org/p/eYUX4vZzNB 

What is the expected output?

"GET / HTTP/1.1\r\nheader:foo\r\n\r\n" <nil>
"GET / HTTP/1.1\r\nheader:foo\r\n" unexpected EOF
"" EOF

What do you see instead?

"GET / HTTP/1.1\r\nheader:foo\r\n\r\n" <nil>
"GET / HTTP/1.1\r\nheader:foo\r\n" EOF
"" unexpected EOF

Please provide any additional information below.

I expect ReadRequest to return io.ErrUnexpectedEOF when the stream ends in the middle of
a request and io.EOF when the stream ends at a request boundary.  The opposite errors
are returned.
@rsc
Copy link
Contributor

rsc commented Mar 12, 2012

Comment 1:

I agree that the answers are <nil>, ErrUnexpectedEOF, and EOF.
Brad, interested?

Labels changed: added priority-go1, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

Comment 2:

This issue was closed by revision e8deb3f.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants