Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive/tar: add FileInfoHeader function for symmetry with archive/zip #3295

Closed
bradfitz opened this issue Mar 12, 2012 · 6 comments
Closed

archive/tar: add FileInfoHeader function for symmetry with archive/zip #3295

bradfitz opened this issue Mar 12, 2012 · 6 comments
Labels
FrozenDueToAge

Comments

@bradfitz
Copy link
Contributor 

Making a tar.Header is a pain.

archive/zip has a FileInfoHeader function to make it.

archive/tar should too.
@rsc
Copy link
Contributor

rsc commented Mar 12, 2012

Comment 1:

Marking Go1 only so that misc/dist has the possibility of using it.
Someone needs to implement the right code one way or another.
It should be possible to translate from os.FileMode to tar Mode
without invoking syscall.Stat_t.  See also issue #3296.

Labels changed: added priority-go1, removed priority-triage.

Owner changed to @dsymonds.

Status changed to Accepted.

@bradfitz
Copy link
Contributor Author

Comment 2:

Taking.

Owner changed to @bradfitz.

@bradfitz
Copy link
Contributor Author

Comment 3:

http://golang.org/cl/5796073

@bradfitz
Copy link
Contributor Author

Comment 4:

Sounds like Sydney is thinking not for Go 1.
We can move this into bindist.go or something.

@adg
Copy link
Contributor

adg commented Mar 14, 2012

Comment 5:

Labels changed: added priority-later, removed priority-go1.

@bradfitz
Copy link
Contributor Author

Comment 6:

This issue was closed by revision 2b98401.

Status changed to Fixed.

@bradfitz bradfitz self-assigned this May 24, 2012
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @rsc @adg @gopherbot