Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/tip: _tipstatus endpoint error is not cleared on successful process start #32949

Closed
dmitshur opened this issue Jul 5, 2019 · 4 comments
Closed

x/build/cmd/tip: _tipstatus endpoint error is not cleared on successful process start #32949

dmitshur opened this issue Jul 5, 2019 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 5, 2019

At this moment, https://tip.golang.org/_tipstatus shows that it's currently running the latest commits from Go and x/website repos:

current=go=e94472a3/website=61d83737

However, it also shows an non-nil error:

error=builder.Init: checkout of go: reset: fatal: ambiguous argument '': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

exit status 128

I've noticed that it seems to be showing an error most of the time, yet tip.golang.org seems to be fine. Either it's showing a previous error, or something else. We should figure out why it's happening and make it so that it shows nil error most of the time. A non-nil error should represent a legitimate issue.

/cc @toothrot FYI.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 5, 2019
@dmitshur dmitshur added this to the Unreleased milestone Jul 5, 2019
@dmitshur dmitshur mentioned this issue Jul 5, 2019
Closed
@dmitshur dmitshur self-assigned this Jul 5, 2019
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 5, 2019
@gopherbot
Copy link

Change https://golang.org/cl/185138 mentions this issue: cmd/tip: improve precondition checking, less ambiguous arguments

@gopherbot
Copy link

Change https://golang.org/cl/185139 mentions this issue: cmd/tip: clear error when process starts successfully

@dmitshur dmitshur changed the title x/build/cmd/tip: _tipstatus endpoint error seems flaky (often shows an error while everything seems okay) x/build/cmd/tip: _tipstatus endpoint error is not cleared on successful process start Jul 5, 2019
@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 5, 2019

The problem was that the error was never cleared, so it indeed always showed the "last error", not "current error". I've sent 2 CLs, one to improve precondition checking, the other to fix this issue.

gopherbot pushed a commit to golang/build that referenced this issue Jul 9, 2019
@dmitshur
cmd/tip: improve precondition checking, less ambiguous arguments
7e427ad 
Check that the required repository HEAD revisions are present before
attempting to clone said repositories.

Use '--' to separate paths and make git invocations less ambiguous.

Updates golang/go#32949

Change-Id: Ie0c771c38a047d674fea5a74318ed396fd03c7ce
Reviewed-on: https://go-review.googlesource.com/c/build/+/185138
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@gopherbot
Copy link

Change https://golang.org/cl/185981 mentions this issue: cmd/coordinator: add health item for tip.golang.org

gopherbot pushed a commit to golang/build that referenced this issue Jul 15, 2019
@dmitshur
cmd/coordinator: add health item for tip.golang.org
ebc4ca1 
This change adds health monitoring for the tip.golang.org website
to farmer.golang.org#health, so we can know when there's an issue
with it without having to manually check it separately from every
other item already monitored at farmer.golang.org#health.

This is possible now that golang/go#32949 is resolved and
the _tipstatus page reports currently ongoing errors only.

Tested by running coordinator locally in dev mode.

Fixes golang/go#15266
Updates golang/go#32949

Change-Id: I3680a916e4b45336df837c72ac7bc555d37f3a9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/185981
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@dmitshur @codebien
cmd/tip: improve precondition checking, less ambiguous arguments
4c52ef1 
Check that the required repository HEAD revisions are present before
attempting to clone said repositories.

Use '--' to separate paths and make git invocations less ambiguous.

Updates golang/go#32949

Change-Id: Ie0c771c38a047d674fea5a74318ed396fd03c7ce
Reviewed-on: https://go-review.googlesource.com/c/build/+/185138
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@dmitshur @codebien
cmd/tip: clear error when process starts successfully
27bed84 
We want the error to represent an ongoing problem. It's less useful
to constantly show the last error; we have logs for that.

This will help make the _tipstatus output more readable for humans,
and more friendly to being monitored by farmer.golang.org#health.

Updates golang/go#15266
Fixes golang/go#32949

Change-Id: I20e5f180209c54b31e81e29bd45af0e2d205d3cc
Reviewed-on: https://go-review.googlesource.com/c/build/+/185139
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@dmitshur @codebien
cmd/coordinator: add health item for tip.golang.org
7c441dd 
This change adds health monitoring for the tip.golang.org website
to farmer.golang.org#health, so we can know when there's an issue
with it without having to manually check it separately from every
other item already monitored at farmer.golang.org#health.

This is possible now that golang/go#32949 is resolved and
the _tipstatus page reports currently ongoing errors only.

Tested by running coordinator locally in dev mode.

Fixes golang/go#15266
Updates golang/go#32949

Change-Id: I3680a916e4b45336df837c72ac7bc555d37f3a9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/185981
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot