Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/big: arm64 assembly code for shlVU is incorrect [1.12 backport] #32940

Closed
gopherbot opened this issue Jul 4, 2019 · 11 comments
Closed

math/big: arm64 assembly code for shlVU is incorrect [1.12 backport] #32940

gopherbot opened this issue Jul 4, 2019 · 11 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.9

Comments

@gopherbot
Copy link

@erifan requested issue #31084 to be considered for backport to the next 1.13 minor release.

@gopherbot Please open backport issue to 1.13
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 4, 2019
@gopherbot gopherbot mentioned this issue Jul 4, 2019
Closed
@dmitshur

This comment has been minimized.

Sign in to view
@dmitshur dmitshur closed this as completed Jul 5, 2019
@ALTree ALTree removed the CherryPickCandidate Used during the release process for point releases label Jul 5, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Jul 8, 2019

Targeting 1.12 and reopening for consideration per #31084 (comment).

@dmitshur dmitshur reopened this Jul 8, 2019
@dmitshur dmitshur added this to the Go1.12.7 milestone Jul 8, 2019
@dmitshur dmitshur changed the title math/big: arm64 assembly code for shlVU is incorrect [1.13 backport] math/big: arm64 assembly code for shlVU is incorrect [1.12 backport] Jul 8, 2019
@dmitshur dmitshur added the CherryPickCandidate Used during the release process for point releases label Jul 8, 2019
@ianlancetaylor
Copy link
Contributor

I think it's fine to backport https://golang.org/cl/169780 to the 1.12 branch.

I don't think it's a release blocker, as the problem is not new.

@toothrot toothrot modified the milestones: Go1.12.7, Go1.12.8 Jul 8, 2019
@toothrot
Copy link
Contributor

toothrot commented Jul 8, 2019

Moving to Go1.12.8 because there is no backport CL ready in time for this release.

@gopherbot
Copy link
Author

Change https://golang.org/cl/185041 mentions this issue: [release-branch.go1.12] math/big: fix the bug in assembly implementation of shlVU on arm64

gopherbot pushed a commit that referenced this issue Aug 2, 2019
@ianlancetaylor
[release-branch.go1.12] math/big: fix the bug in assembly implementat…
2da8ca4 
…ion of shlVU on arm64

For the case where the addresses of parameter z and x of the function
shlVU overlap and the address of z is greater than x, x (input value)
can be polluted during the calculation when the high words of x are
overlapped with the low words of z (output value).

Updates #31084
Fixes #32940

Change-Id: I9bb0266a1d7856b8faa9a9b1975d6f57dece0479
Reviewed-on: https://go-review.googlesource.com/c/go/+/169780
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit 503e6cc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/185041
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@ianlancetaylor
Copy link
Contributor

Not sure why gopherbot hasn't closed this yet.

@dmitshur
Copy link
Contributor

dmitshur commented Aug 6, 2019 •
edited

Not sure why gopherbot hasn't closed this yet.

It was because of #31094. This issue was closed and re-opened earlier, and gopherbot uses the presence of the "reopened" event as a fallible heuristic to avoid fighting people.

@dmitshur dmitshur mentioned this issue Aug 6, 2019
Open
@dmitshur dmitshur modified the milestones: Go1.12.8, Go1.12.9 Aug 13, 2019
@erifan
Copy link

erifan commented Aug 15, 2019

Hi @dmitshur , I saw Go1.12.8 has been released, but this backport does not seem to go in.

@dmitshur
Copy link
Contributor

@erifan This is expected. Go 1.12.8 was a security release, so its contents are just Go 1.12.7 with the security fixes applied. The next point release, Go 1.12.9, will include both the security fixes from 1.12.8 and all other changes that have been backported to the 1.12 release branch (release-branch.go1.12) since 1.12.7. This backport will be included.

@erifan
Copy link

erifan commented Aug 15, 2019

Ok, I see, thanks.

@dmitshur
Copy link
Contributor

This backport has been approved and merged to the release branch; updating label to CherryPickApproved to reflect that. The rationale was that this was a serious problem affecting arm64 with no workaround.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 15, 2019
This was referenced Aug 19, 2019
Closed
Closed
@golang golang locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.9
Development

No branches or pull requests
6 participants
@toothrot @dmitshur @ianlancetaylor @ALTree @gopherbot @erifan