Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: needs better diagnostics for vcs tool not found #3292

Closed
adg opened this issue Mar 12, 2012 · 6 comments
Closed

cmd/go: needs better diagnostics for vcs tool not found #3292

adg opened this issue Mar 12, 2012 · 6 comments

Comments

@adg
Copy link
Contributor

adg commented Mar 12, 2012

It would help to tell people where to get the tools if they don't have them. (and why
they need them)
@adg
Copy link
Contributor Author

adg commented Mar 12, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

@bradfitz
Copy link
Contributor

Comment 2:

I thought this bug was about bad error messages from the Go tool if hg/git/svn weren't
found, but they're quite fine, IMO:
package code.google.com/p/rsc: exec: "hg": executable file not found in $PATH
I'm not sure we need more than that.
Then we'd be detecting which of twenty distros the user has and recommending the correct
apt-get/yum/pkg_add command.
Re-assigning back to adg.

Owner changed to @adg.

Status changed to WaitingForReply.

@rsc
Copy link
Contributor

rsc commented Mar 12, 2012

Comment 3:

Agree with Brad.  We used to have various hand-holding
errors in go/build and they turned out to be infinitely confusing
when they were wrong.  I deleted them all during the go/build
rewrite.
To apply to the current case, suppose we printed something
about 'you don't have Mercurial installed; run this' when in
fact they do have Mercurial installed, it's just not in their path.
Let's let the error say what it knows and not assume it knows more.
Russ

@rsc
Copy link
Contributor

rsc commented Mar 15, 2012

Comment 4:

In the absense of any argument, closing the bug.

Status changed to WorkingAsIntended.

@adg
Copy link
Contributor Author

adg commented Mar 20, 2012

Comment 5:

I would prefer it if we at least said "You need Mercurial installed" or similar. "hg"
doesn't mean anything to someone who has never used Mercurial.

Labels changed: added priority-later, removed priority-go1.

Status changed to New.

@adg
Copy link
Contributor Author

adg commented Apr 19, 2012

Comment 6:

Status changed to Retracted.

@adg adg self-assigned this Apr 19, 2012
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants